1794038 - Intermittent toolkit/components/glean/tests/xpcshell/test_GIFFT.js | single tracking bug

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mlaza [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=392495268&repo=mozilla-beta
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/K2dZisIFQ2O4AJiQrNZzQQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2022-10-06T20:20:50.205Z] 20:20:50     INFO -  TEST-START | toolkit/components/glean/tests/xpcshell/test_GIFFT.js
[task 2022-10-06T20:20:50.364Z] 20:20:50  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/glean/tests/xpcshell/test_GIFFT.js | xpcshell return code: 0
[task 2022-10-06T20:20:50.376Z] 20:20:50     INFO -  TEST-INFO took 160ms
[task 2022-10-06T20:20:50.376Z] 20:20:50     INFO -  >>>>>>>
[task 2022-10-06T20:20:50.376Z] 20:20:50     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2022-10-06T20:20:50.376Z] 20:20:50     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2022-10-06T20:20:50.376Z] 20:20:50     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2022-10-06T20:20:50.377Z] 20:20:50     INFO -  running event loop
[task 2022-10-06T20:20:50.377Z] 20:20:50     INFO -  toolkit/components/glean/tests/xpcshell/test_GIFFT.js | Starting setup test_setup
[task 2022-10-06T20:20:50.377Z] 20:20:50     INFO -  (xpcshell/head.js) | test test_setup pending (2)
[task 2022-10-06T20:20:50.377Z] 20:20:50     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2022-10-06T20:20:50.377Z] 20:20:50     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2022-10-06T20:20:50.378Z] 20:20:50     INFO -  (xpcshell/head.js) | test test_setup finished (2)
[task 2022-10-06T20:20:50.378Z] 20:20:50     INFO -  toolkit/components/glean/tests/xpcshell/test_GIFFT.js | Starting test_gifft_counter
[task 2022-10-06T20:20:50.378Z] 20:20:50     INFO -  (xpcshell/head.js) | test test_gifft_counter pending (2)
[task 2022-10-06T20:20:50.378Z] 20:20:50     INFO -  TEST-PASS | toolkit/components/glean/tests/xpcshell/test_GIFFT.js | test_gifft_counter - [test_gifft_counter : 49] 20 == 20

Comment 1

[Chris H-C :chutten]

[task 2022-10-06T20:20:50.418Z] 20:20:50  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/glean/tests/xpcshell/test_GIFFT.js | test_gifft_timespan - [test_gifft_timespan : 311] 9 >= 10

Why do I get the feeling this is another bug 1777638, but timespan instead of timing_distribution...

...oh, because it is. It is possible (though unlikely) for a 10ms timer to take less than 10ms to run. Telemetry truncates the almost-10ms value.

This means we need to change this line to be >= 9. I did a quick check and I don't think there's another timespan test that could be affected. (It isn't in the IPC test because timespan metric operations are not commutative.

Comment 2

[Intermittent Failures Robot]

2 failures in 2449 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1
• mozilla-release: 1

Platform and build breakdown:

• windows10-64-2004-shippable-qr: 1
  • opt: 1
• windows7-32-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1794038&startday=2022-10-03&endday=2022-10-09&tree=all

Comment 3

[Intermittent Failures Robot]

2 failures in 3743 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 1
• mozilla-beta: 1

Platform and build breakdown:

• windows10-64-2004-shippable-qr: 1
  • opt: 1
• windows10-64-2004-devedition-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1794038&startday=2022-10-24&endday=2022-10-30&tree=all

Comment 4

[Intermittent Failures Robot]

1 failures in 3626 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform and build breakdown:

• windows10-64-2004-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1794038&startday=2022-10-31&endday=2022-11-06&tree=all

Comment 5

[Bruno Rosa [:brosa]]

Attachment: Bug 1794038 - Update test_gifft_timespan test to avoid intermittent failures. r=chutten

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec4f130d3b7c
Update test_gifft_timespan test to avoid intermittent failures. r=chutten

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ec4f130d3b7c