1794156 - Clean up mail/locales/l10n.toml file & mail/locales/Makefile.in

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Description

[Rob Lemley [:rjl]]

There's some cruft in mail/locales/l10n.toml that could be removed.

[[paths]]
    reference = "editor/ui/locales/en-US/**"
    l10n = "{l}editor/ui/**"

The editor directory was removed sometime between esr78 and esr91.

[[paths]]
    reference = "other-licenses/branding/thunderbird/locales/en-US/**"
    l10n = "{l}other-licenses/branding/thunderbird/**"

The other-licenses/branding/thunderbird was removed between esr52 and esr60, with the remains of other-licenses/branding being removed between esr60 and esr68.

# for Gecko 60 and older and cross-channel
[[paths]]
    reference = "{mozilla}/devtools/shim/locales/en-US/**"
    l10n = "{l}devtools/shim/**"

There's no devtools/shim apparently since post-esr60. This can go.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1794156 - Remove mapit prefs and js. r=aleca

These prefs are not used anymore by Thunderbird (they are for Seamonkey, so they
are #ifdef wrapped in mailnews.js). The javascript is not loaded by Thunderbird,
but is still shipped.

Removing these prefs allows for cleanup of l10n.toml and should mean that the
remaining prefs will be exposed for localization in Pontoon again.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1794156 - Clean up old entries in mail/locales/l10n.toml. r=#thunderbird-reviewers

Depends on D158869

Comment 3

[Rob Lemley [:rjl]]

Adding to this bug, mail/locales/Makefile.in has a bunch of stuff in it that should be moved into moz.build.
Oh and there needs to be a crashreporter-override.ini file jammed in there somehow.

Comment 4

[Rob Lemley [:rjl]]

Attachment: Bug 1794156 - Port bug 1409721: Add crashreporter-override.ini for Thunderbird. r=#thunderbird-reviewers

The referenced bug is where Firefox moved crashreporter-override.ini into
its moz.build file. It existed prior to that. Thunderbird never seems to
have had it, though Seamonkey does.

Depends on D158870

Comment 5

[Rob Lemley [:rjl]]

Attachment: Bug 1794156 - Port bug 1416891: Move updater localization into moz.build. r=#thunderbird-reviewers

Depends on D159408

Comment 6

[Rob Lemley [:rjl]]

Attachment: Bug 1794156 - Port bug 1514806: Move 7z SFX stub configuration into Taskgraph/mozharness configs. r=#thunderbird-reviewers

From D15983.

Depends on D159409

Comment 7

[Rob Lemley [:rjl]]

Attachment: Bug 1794156 - Port bug 1409721: Move localized prefs file into moz.build. r=#thunderbird-reviewers

Depends on D159410

Comment 8

[Rob Lemley [:rjl]]

Attachment: Bug 1794156 - Drive-by cleanup of mail/locales/Makefile.in. r=#thunderbird-reviewers

The "l10n-check" target is no longer relevant since Bug 1607193.
"prepare-upload-*" and "prepare-repackages" do not seem to be run anymore, and
nothing else references these targets. Removal should have no effect.

Depends on D159411

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/93670bb77046
Remove mapit prefs and js. r=aleca
https://hg.mozilla.org/comm-central/rev/206f26714cdc
Clean up old entries in mail/locales/l10n.toml. r=mkmelin
https://hg.mozilla.org/comm-central/rev/7eba249baf3c
Port bug 1409721: Add crashreporter-override.ini for Thunderbird. r=mkmelin
https://hg.mozilla.org/comm-central/rev/245f96073338
Port bug 1416891: Move updater localization into moz.build. r=mkmelin
https://hg.mozilla.org/comm-central/rev/46395d0251e7
Port bug 1514806: Move 7z SFX stub configuration into Taskgraph/mozharness configs. r=mkmelin
https://hg.mozilla.org/comm-central/rev/fbe3d78d1e22
Port bug 1409721: Move localized prefs file into moz.build. r=mkmelin
https://hg.mozilla.org/comm-central/rev/5091bde394d1
Drive-by cleanup of mail/locales/Makefile.in. r=mkmelin