1794250 - remove/inline *CID.h definitions for thunderbird components

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Magnus Melin [:mkmelin]]

We still have a bunch of CID.h files around, even if those are no longer any kind of authoritative source of information since everything goes through .conf files now. (Bug 1773772 and others.) At the moment they only give an extra layer of needless confusion.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - inline *_CIDs used by NS_DEFINE_CID. r=#thunderbird-reviewers

... and correct a few things that couldn't be easily semi-scripted.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsMsgCompCID.h. r=#thunderbird-reviewers

Depends on D159985

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsMailMigrationCID.h. r=#thunderbird-reviewers

Depends on D159986

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsMsgBaseCID.h. r=benc

Depends on D159987

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsMsgImapCID.h. r=#thunderbird-reviewers

Depends on D159988

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsMsgLocalCID.h. r=#thunderbird-reviewers

Depends on D159989

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsMsgSMIMECID.h. r=#thunderbird-reviewers

Depends on D159990

Comment 8

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsMsgMdnCID.h. r=#thunderbird-reviewers

Depends on D159991

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsFts3TokenizerCID.h. r=#thunderbird-reviewers

Depends on D159992

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsBayesianFilterCID.h. r=#thunderbird-reviewers

Depends on D159993

Comment 11

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsMsgMailViewsCID.h. r=#thunderbird-reviewers

Depends on D159994

Comment 12

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsMorkCID.h. r=#thunderbird-reviewers

Depends on D159995

Comment 13

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsMsgDBCID.h. r=#thunderbird-reviewers

Depends on D159996

Comment 14

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsAbBaseCID.h. r=#thunderbird-reviewers

Depends on D159997

Comment 15

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove msgJsAccountCID.h. r=#thunderbird-reviewers

Depends on D159998

Comment 16

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsCommUConvCID.h. r=#thunderbird-reviewers

Depends on D159999

Comment 17

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsMimeEmitterCID.h. r=#thunderbird-reviewers

Depends on D160000

Comment 18

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsMsgMimeCID.h. r=#thunderbird-reviewers

Depends on D160001

Comment 19

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsMsgNewsCID.h. r=#thunderbird-reviewers

Depends on D160002

Comment 20

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove nsMsgSMIMECID.h. r=#thunderbird-reviewers

Depends on D160003

Comment 21

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - remove calBaseCID.h. r=#thunderbird-reviewers

Depends on D160004

Comment 22

[Magnus Melin [:mkmelin]]

Attachment: Bug 1794250 - fix black-linting for removed includes. r=#thunderbird-reviewers

Depends on D160005

Comment 23

[Magnus Melin [:mkmelin]]

D159985 is what I couldn't easily semi-script.

Comment 24

[Alessandro Castellani [:aleca]]

Gentle ping to Ben to ask him to review this batch of patches.

Comment 25

[Ben Campbell]

Just a couple of minor #define glitches to iron out, but otherwise looks great!

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/79a6efa297e6
inline *_CIDs used by NS_DEFINE_CID. r=benc
https://hg.mozilla.org/comm-central/rev/27c4aa5c1fe2
remove nsMsgCompCID.h. r=prev
https://hg.mozilla.org/comm-central/rev/b7f380632f7d
remove nsMailMigrationCID.h. r=prev
https://hg.mozilla.org/comm-central/rev/3656815f2086
remove nsMsgBaseCID.h. r=benc
https://hg.mozilla.org/comm-central/rev/c1b2f6d57ff5
remove nsMsgImapCID.h. r=benc
https://hg.mozilla.org/comm-central/rev/dce06ba91714
remove nsMsgLocalCID.h. r=benc
https://hg.mozilla.org/comm-central/rev/01e0e44f27af
remove nsMsgMdnCID.h. r=benc
https://hg.mozilla.org/comm-central/rev/014b15902ff1
remove nsFts3TokenizerCID.h. r=benc
https://hg.mozilla.org/comm-central/rev/53a935967ccc
remove nsBayesianFilterCID.h. r=benc
https://hg.mozilla.org/comm-central/rev/418b24499f22
remove nsMsgMailViewsCID.h. r=prev
https://hg.mozilla.org/comm-central/rev/040499f993e6
remove nsMorkCID.h. r=benc
https://hg.mozilla.org/comm-central/rev/c03798848d0c
remove nsMsgDBCID.h. r=benc
https://hg.mozilla.org/comm-central/rev/4fe0b5dba912
remove nsAbBaseCID.h. r=benc
https://hg.mozilla.org/comm-central/rev/7a7b74779c8d
remove msgJsAccountCID.h. r=benc
https://hg.mozilla.org/comm-central/rev/b29f8d75473e
remove nsCommUConvCID.h. r=benc
https://hg.mozilla.org/comm-central/rev/1d8c14496365
remove nsMimeEmitterCID.h. r=benc
https://hg.mozilla.org/comm-central/rev/135e74a4fab8
remove nsMsgMimeCID.h. r=benc
https://hg.mozilla.org/comm-central/rev/c1369c6a1968
remove nsMsgNewsCID.h. r=benc
https://hg.mozilla.org/comm-central/rev/2d2a340b8346
remove nsMsgSMIMECID.h. r=benc
https://hg.mozilla.org/comm-central/rev/2be703e3c93f
remove calBaseCID.h. r=benc
https://hg.mozilla.org/comm-central/rev/32c3c20db582
fix black-linting for removed includes. r=benc

Comment 27

[Martin Giger [:freaktechnik]]

I think this missed some spots in mailnews/addrbook/src/nsAbOSXCard.mm and mailnews/addrbook/src/nsAbOSXDirectory.mm https://treeherder.mozilla.org/logviewer?job_id=394222910&repo=comm-central&lineNumber=8343

Comment 28

[Rob Lemley [:rjl]]

Attachment: Bug 1794250 - Follow-up: Inline #defines for macOS AB support lost in nsAbBaseCID.h removal. r=#thunderbird-reviewers

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a2958dfb3462
Follow-up: Inline #defines for macOS AB support lost in nsAbBaseCID.h removal. r=freaktechnik

Comment 30

[Magnus Melin [:mkmelin]]

Ah, thanks for taking care!