Closed Bug 1794272 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36351 - Prevent ::backdrop from being a list item

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36351 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36351
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

Prevent ::backdrop from being a list item

The ::backdrop pseudo-element is kind of special because, despite not
being tree-abiding, accepts arbitrary styles like 'display: list-item'.
This is a problem because list items have a ListItemOrdinal, which needs
to traverse the tree.

So this patch prevents ::backdrop from becoming a list item.

This avoids some DCHECK failures in debug builds, but I believe it will
have no observable effect in release builds since ::backdrop was already
not allowed to originate a nested ::marker.

Bug: 1371331

TEST=external/wpt/fullscreen/crashtests/backdrop-list-item.html

Change-Id: I984bac3f81eb51f42bcdbd51e3cb9498d954f374
Reviewed-on: https://chromium-review.googlesource.com/3933059
WPT-Export-Revision: 06cbc1fd964ccf4b295af9443cb6119c4c33ebbe

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0c5133a10467 [wpt PR 36351] - Prevent ::backdrop from being a list item, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.