Switching to an RTL language is broken (live language switching)
Categories
(Thunderbird :: General, defect)
Tracking
(thunderbird_esr102 fixed)
Tracking | Status | |
---|---|---|
thunderbird_esr102 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [TM:102.4.1])
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta-
wsmwk
:
approval-comm-esr102+
|
Details | Review |
STR
- Install Thunderbird 102.3.1 with a ltr language.
- In settings under languages, choose set alternatives then add an rtl language.
- Exit the sub-prompt and select the new language.
Expected results
UI is changed to the new language.
Actual Results
Nothing happens, not even after restart.
On the error console this is displayed when the message is selected:
08:42:57.675 Uncaught (in promise) ReferenceError: can't access lexical declaration 'description' before initialization
showConfirmLanguageChangeMessageBar chrome://messenger/content/preferences/general.js:1255
general.js:1255:9
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/0fc3fc264e1d
Fix switching the language to RTL based locales. r=mkmelin
Assignee | ||
Comment 3•2 years ago
|
||
Comment on attachment 9297726 [details]
Bug 1794289 - Fix switching the language to RTL based locales. r?mkmelin
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Beta/Release Uplift Approval Request
- User impact if declined: Switching to RTL locales using dynamic switching will be broken
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See comment 0
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Corrects some code that was copied from Firefox but placed in the wrong spot.
- String changes made/needed: None
- Is Android affected?: No
Assignee | ||
Updated•2 years ago
|
Comment 4•2 years ago
|
||
Comment on attachment 9297726 [details]
Bug 1794289 - Fix switching the language to RTL based locales. r?mkmelin
[Triage Comment]
Approved for beta
Updated•2 years ago
|
Comment 5•2 years ago
|
||
It missed beta, so we'll catch the next point release
Updated•2 years ago
|
Comment 6•1 year ago
|
||
Comment on attachment 9297726 [details]
Bug 1794289 - Fix switching the language to RTL based locales. r?mkmelin
[Triage Comment]
Approved for esr102
Comment 7•1 year ago
|
||
Comment on attachment 9297726 [details]
Bug 1794289 - Fix switching the language to RTL based locales. r?mkmelin
[Triage Comment]
fixing flag
Comment 8•1 year ago
|
||
bugherder uplift |
Thunderbird 102.4.1:
https://hg.mozilla.org/releases/comm-esr102/rev/9af8371d1f7e
Description
•