1794386 - Sanitize file names used with IOUtils.createUniqueFile() in WebExtension APIs

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, task)

Description

[John Bieling (:TbSync)]

Follow-up to bug 1782173.

Comment 1

[John Bieling (:TbSync)]

Attachment: Bug 1794386 - Sanitize file names used with IOUtils.createUniqueFile() in WebExtension APIs. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1c65152e5306
Sanitize file names used with IOUtils.createUniqueFile() in WebExtension APIs. r=mkmelin

Comment 3

[John Bieling (:TbSync)]

Comment on attachment 9297806 [details]
Bug 1794386 - Sanitize file names used with IOUtils.createUniqueFile() in WebExtension APIs. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
File names are not sanitized and could lead to unexpected erros.

Testing completed (on c-c, etc.):
On beta for more than 30 days

Risk to taking this patch (and alternatives if risky):
Low.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9297806 [details]
Bug 1794386 - Sanitize file names used with IOUtils.createUniqueFile() in WebExtension APIs. r=mkmelin

[Triage Comment]
Approved for esr102

Comment 5

[Rob Lemley [:rjl]]

John - This doesn't apply on c-esr102. It looks like it may need bug 1646473?

Comment 6

[John Bieling (:TbSync)]

Oh wow, you are correct. We cannot / should not uplift that other bug, and it looks like this uplift is not needed then at all. Setting it to not affected.

Comment 7

[Rob Lemley [:rjl]]

Comment on attachment 9297806 [details]
Bug 1794386 - Sanitize file names used with IOUtils.createUniqueFile() in WebExtension APIs. r=mkmelin

Canceling uplift request per TbSync.