1794407 - [macOS] Drop-down menu check mark is overlapping text if the Zoom level is increased inside a PDF Form

Status: VERIFIED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: Screenshot 2022-10-10 at 16.23.20.png

Found in

• 107.0a1 (20221010033207)

Affected versions

• 107.0a1 (20221010033207)
• 106.0b9 (20221006191955)

Tested platforms

• Affected platforms: macOS 11.6
• Unaffected platforms: Windows 10x64, Ubuntu 20.04

Steps to reproduce

1. Open http://foersom.com/net/HowTo/data/OoPdfFormExample.pdf.
2. Increase the Zoom level (e.g 200%).
3. Open a random drop-down that contains a selection. (e.g Gender)

Expected result

• The text is displayed correctly and does not overlap with the check mark.

Actual result

• The checkmark overlaps the text.

Regression range

• Last good revision: e258251923f9e1bc746319aa0dbb916bbdbaf8bb
  First bad revision: d938816c9cd1876cd724db059a54a3ba31a2b97c
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e258251923f9e1bc746319aa0dbb916bbdbaf8bb&tochange=d938816c9cd1876cd724db059a54a3ba31a2b97c
  Potential regressor: bug 1791108.

Additional notes

• Attached a screenshot with the issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1791108, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Can we back out the regressing patch from beta? It should be safe to uplift this too instead, but also it was fixing a long-standing regression, so probably not worth the risk.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1794407 - More reliable OSX menulist styling. r=jfkthame,mstange

So that they work with increased zoom leves on <select>. This
effectively happened before, because width on XUL was being treated like
min-width, effectively.

Comment 4

[Pascal Chevrel:pascalc (PTO until April 26)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

Can we back out the regressing patch from beta? It should be safe to uplift this too instead, but also it was fixing a long-standing regression, so probably not worth the risk.

We ended betas last Friday and just shipped our release candidate

Comment 5

[Jonathan Kew [:jfkthame]]

Attachment: Screenshot of zoomed-in menu with D158978 patch

I don't think this is working quite as intended.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

I get that for testing on Linux with the macOS styles on top. Thanks :-)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/862b29c567ef
More reliable OSX menulist styling. r=jfkthame,mstange

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures in toolkit/content/tests/chrome/test_menulist_position.xhtml

Backout link: https://hg.mozilla.org/integration/autoland/rev/bdc0e040908c60099e6d3010da49a4452735609b

Push with failures

Failure log

TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_menulist_position.xhtml | Labels horizontally aligned for index 0

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c21f18c56e54
More reliable OSX menulist styling. r=jfkthame,mstange,desktop-theme-reviewers,dao

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c21f18c56e54

Comment 11

[Alexandru Trif, Desktop QA [:atrif]]

I can confirm that this issue is fixed with Firefox 107.0a1 (20221013224755) on macOS 10.15 for PDF from comment 0 with increased zoom. However, I can reproduce bug 1795232 but I think that will be treated separately so I'm closing this as verified. Please reopen if necessary. Thank you!