1794424 - Consider whether "with" is still needed in test_bug732665.xhtml

Status: RESOLVED FIXED

(Core :: XPConnect, task, P3)

Description

[Andrew McCreight [:mccr8]]

test_bug732665.xhtml (and the shell version in test_bug732665_meta.js) probe the stack depth, and use a with to "keep things predictable -- stay in the interpreter". kmag suggests that maybe this isn't really needed. For what it is worth, I removed it from the mochitest locally and it still passes with --verify.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1794424: Stop using `with()` to try to avoid the JIT. r=mccr8,jandem

It shouldn't actually keep us out of Baseline anymore, and eval should be
enough to prevent any heavy optimization.

I tried replacing the eval() with Cu.exportFunction to create native stack
frames in a definitely-not-JITtable way, but the frames were too small, and
the stub JS function calls started failing with stack overflow errors at the
same time as the "heavy" native calls.

That also happened to uncover a fairly obvious bug in the existing test, in
that we can't actually report a failed assertion when we're out of stack
space, and just wind up throwing another stack overflow or allocation error
instead.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b6eb1b0bf8b
Stop using `with()` to try to avoid the JIT. r=jandem,mccr8

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7b6eb1b0bf8b