Open Bug 1794489 Opened 2 years ago Updated 1 year ago

[Cleanup] Refactor MRColorways handling of variations

Categories

(Firefox :: Messaging System, task, P3)

Product:
Firefox
Component:
Messaging System
Type:
task

Tracking

()

People

(Reporter: pdahiya, Unassigned)

References

(Blocks 1 open bug)

Details

Existing user upgrade dialog spotlight dark behavior is different from about:welcome dark behavior which relies on content styling causing to special handle darkVariation in OnboardingMessageProvider.jsm

Scope of this bug is to simplify handling dark and light theme logic by removing system variations array

https://searchfox.org/mozilla-central/rev/ffa4d00965c5281def6d3ddcbcdf6259d38c9b9a/browser/components/newtab/content-src/aboutwelcome/components/MRColorways.jsx#129

https://phabricator.services.mozilla.com/D157161#inline-865909

Priority: -- → P2
Assignee: nobody → halemu
Assignee: halemu → nobody
Iteration: --- → 109.1 - Nov 14 - Nov 25
Summary: Refactor MRColorways handling of variations → [Cleanup] Refactor MRColorways handling of variations
Iteration: 109.1 - Nov 14 - Nov 25 → 109.2 - Nov 28 - Dec 9

Is it worth Fixing this considering colorways will be retired soon?

Flags: needinfo?(pdahiya)

Makes sense, will be good to pick this post Fx111 depending on future of colorways. Thanks

Flags: needinfo?(pdahiya)
Priority: P2 → P3
Iteration: 109.2 - Nov 28 - Dec 9 → ---
You need to log in before you can comment on or make changes to this bug.