1794594 - codeql-cpp breaks when migrating from AWS to GCP

Status: RESOLVED FIXED

(Firefox Build System :: General, task, P3)

Description

[Michelle Goossens [:masterwayz]]

codeql-cpp breaks when migrating from AWS to GCP
See https://treeherder.mozilla.org/logviewer?job_id=392032234&repo=try&lineNumber=26088 for logs.

Comment 1

[Andrew Halberstadt [:ahal]]

Looks like the relevant log is:

16:12:58     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/modules/libpref'
16:12:58     INFO -  /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -std=gnu++17 -o Unified_cpp_modules_libpref0.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -ftrivial-auto-var-init=pattern -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DOS_ARCH=Linux -DMOZ_WIDGET_TOOLKIT=gtk -DMOZ_SERVICES_SYNC -DMOZ_BUILD_APP_IS_BROWSER -DMOZ_BACKGROUNDTASKS -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/modules/libpref -I/builds/worker/workspace/obj-build/modules/libpref -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wenum-compare-conditional -Wno-ambiguous-reversed-operator -Wno-error=deprecated -Wno-error=deprecated-anon-enum-enum-conversion -Wno-error=deprecated-enum-enum-conversion -Wno-error=deprecated-enum-float-conversion -Wno-error=deprecated-pragma -Wno-error=deprecated-this-capture -Wno-error=deprecated-volatile -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Os -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/Unified_cpp_modules_libpref0.o.pp   Unified_cpp_modules_libpref0.cpp
16:12:58    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:669: Unified_cpp_modules_libpref0.o] Error 1
16:12:58     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/modules/libpref'
16:12:58    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: modules/libpref/target-objects] Error 2

Hey Tom, looks like you initially stood up this task. Can you tell from the logs if there's a package or something missing from the build image in GCP?

Comment 2

[Andrew Halberstadt [:ahal]]

For context other builds all compile successfully (and are already migrated), so far this is the only one with issues.

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1794594: Remove codeql builds r?freddyb,#build

Comment 4

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

From some greps of the logs, it seems like these are the number of downloads of codeql databases per day since we started.

      2 2020-03-16
     18 2020-03-19
     18 2020-05-22
      1 2020-05-23
      1 2020-05-24
      2 2020-05-26
      1 2020-05-28
      1 2020-06-01
      1 2020-07-22
      1 2020-07-24
      3 2020-08-25
      1 2020-08-26
      4 2020-09-09
      1 2020-09-10
      3 2020-09-21
      1 2020-10-04
      1 2020-11-04
      1 2020-11-09
      4 2021-01-13
      1 2021-03-10
      1 2021-03-17
      1 2021-04-28
      3 2021-04-30
      1 2021-05-06
      1 2021-05-13
      1 2021-06-08
      1 2021-07-15
      1 2021-07-24
      2 2021-08-06
      1 2021-11-07
      2 2022-02-20
     58 2022-02-24
      2 2022-03-11
      2 2022-03-14
      4 2022-03-16
      1 2022-03-21
      4 2022-03-22
      1 2022-04-08
      1 2022-04-11
      3 2022-05-24
      3 2022-05-25
      1 2022-05-27
      1 2022-05-30
      2 2022-05-31
      4 2022-06-02
      1 2022-06-11
      1 2022-06-24
     67 2022-07-21
      1 2022-08-23
      6 2022-08-28
      1 2022-09-03
      1 2022-09-05
      1 2022-09-08
      1 2022-09-22
      1 2022-09-23
      6 2022-09-26
      1 2022-09-30
      1 2022-10-02
      1 2022-10-04
      1 2022-10-06

I think we can just remove the builds and the downloads, hardly anyone uses it, it's always been an annoying manual step every release, and now it's a maintenance burden. (I looked at the job and I have no idea what the issue could be; the last one was pretty subtle.)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38f0f051feeb
Remove codeql builds r=freddyb,firefox-build-system-reviewers,nalexander

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/38f0f051feeb

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/12f4c96070957c5211a068c0746d34a6e95e1eab

Comment 9

[Intermittent Failures Robot]

2 failures in 3856 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-esr102: 2

Platform and build breakdown:

• codeql: 2
  • all: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1794594&startday=2023-02-13&endday=2023-02-19&tree=all