1794630 - Improve splitters for browser chrome use cases.

Status: RESOLVED FIXED

(Firefox :: Theme, task)

Description

[Emilio Cobos Álvarez (:emilio)]

The browser chrome splitters are really trivial, they mostly just want to resize one of the elements, but splitters right now resize across the whole box container (minus non-flexible items depending on resizebefore/resizeafter).

I think we can simplify various bits quite a lot if we do some tweaks to splitters.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1794630 - Implement resize{before,after}=none/sibling for XUL splitters. r=TYLin

This trivially enhances splitters so that resizing a single element,
which is a common thing to do in our front-end code, is easier.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1794630 - Use resizebefore="sibling" for resizing the sidebar. r=Gijs

This is really what we want. Remove the CSS hack so we always flex.

Depends on D159069

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1794630 - Use resize*=sibling for searchbar container. r=dao

This simplifies the widget tracker code to avoid having to remove random
width attributes in all children.

Depends on D159070

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1794630 - Improve behavior of splitters when child box is flexible. r=TYLin,dholbert

This is not easy to test precisely. What the width attribute / property
set is the preferred size, but the boxes can flex expanding that, which
may cause jumps when dragging. This is easy to see with the previous
patches on the urlbar / searchbar split.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f75b1de2fb54
Implement resize{before,after}=none/sibling for XUL splitters. r=TYLin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d08cef967d68
Improve behavior of splitters when child box is flexible. r=TYLin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86161113004d
Use resizebefore="sibling" for resizing the sidebar. r=Gijs

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0d3534da317
Disable the new test for now to avoid orange on Linux.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Need to make the test work with smaller viewports.

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f75b1de2fb54
https://hg.mozilla.org/mozilla-central/rev/d08cef967d68
https://hg.mozilla.org/mozilla-central/rev/86161113004d
https://hg.mozilla.org/mozilla-central/rev/d0d3534da317

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1794630 - Fix and re-enable test_splitter_sibling.xhtml.

Make sure that the relevant box is in the viewport even on automation.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16f084b9ecdb
Fix and re-enable test_splitter_sibling.xhtml.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fde57ffc3be6
Use resize*=sibling for searchbar container. r=dao

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/16f084b9ecdb
https://hg.mozilla.org/mozilla-central/rev/fde57ffc3be6

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Sheriffs, can we back out https://hg.mozilla.org/mozilla-central/rev/fde57ffc3be6 from beta for causing bug 1795199? I'd rather do that than uplifting the relevant fixes.

Comment 16

[Iulian Moraru]

Backed out changeset fde57ffc3be6 from beta for causing Bug 1795199 and as per Emilio's request.

Backout link

Comment 17

[Emilio Cobos Álvarez (:emilio)]

Thanks!