The MR onboarding split screen's main section is missing a shadow
Categories
(Firefox :: Messaging System, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox108 | --- | verified |
People
(Reporter: aminomancer, Assigned: nsauermann)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 1 obsolete file)
Missing shadow (with contrast increased)
The main content section in MR onboarding screens doesn't have a shadow, which looks a little funky since the secondary section does have one. Especially in the responsive layout, where the main section is several times larger than the secondary section. I added a screenshot with the contrast enhanced to make it more noticeable.
That might have been done to prevent the main section's shadow casting on the secondary section, since it's not easy to cast a single shadow for the whole screen without changing the DOM. But we could also prevent that by using clip-path to clip the shadow on the adjacent edges.
Another approach would be to add a ::before pseudo-element on the screen with the dimensions of both sections combined, and cast the shadow from there instead. Something kind of like the #urlbar-background in the browser chrome.
|
||
Comment 2•2 years ago
|
||
The severity field is not set for this bug.
:tspurway, could you have a look please?
For more information, please visit auto_nag documentation.
|
||
Updated•2 years ago
|
Pushed by nsauermann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/931737b7c12c The MR onboarding split screen's main section is missing a shadow r=aminomancer
|
||
Comment 4•2 years ago
|
||
Backed out changeset 931737b7c12c (Bug 1794661) for causing newtab failures on aboutwelcome.scss.
Backout link
Push with failures <--> newtab
Failure Log
|
|
||
Updated•2 years ago
|
Pushed by nsauermann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/63af6af9200c The MR onboarding split screen's main section is missing a shadow Differential Revision: https://phabricator.services.mozilla.com/D159898 r=aminomancer
|
||
Comment 8•2 years ago
|
||
| bugherder | ||
|
||
Updated•2 years ago
|
|
||
Comment 9•1 year ago
|
||
Reproduced this issue on an affected Nightly build from 2022-10-11, on Win 10.
Verified as fixed on Firefox 108.0b5 (20221122190120) and 109.0a1 (20221123213526) on Win 10, Ubuntu 21.04 and macOS 10.15. The entire Onboarding modal has a shadow effect.
Description
•