1794711 - Pending Intent requires FLAG_IMMUTABLE or FLAG_MUTABLE

Status: RESOLVED FIXED

(GeckoView :: General, defect, P2)

Description

[Dan Baker[:dbaker]]

PendigingIntent needs to have a immutable or mutable flag set.

STR:

• Build and run geckoview_example
• Navigate to a site that will ask for camera/microphone permissions.
• Click to allow

Expected Results:

• App will function

Actual Results:

• Crash is seen using geckoview_example

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Chris Peterson [:cpeterson]]

Dan, can you reproduce this crash in Android Firefox or Focus? What site did you test?

I don't have the geckoview_example app on my device. I was not able to reproduce the crash in Firefox when testing the camera/microphone permissions on https://permission.site/, so this bug might be specific to geckoview_example.

Comment 3

[Dan Baker[:dbaker]]

Chris, this is specific I believe to the geckoview_example project the site you listed crashed for me when requesting camera permissions. If you also see the link I posted https://searchfox.org/mozilla-central/rev/f118dae98073bc17efb8604a32abfcb7b4e05880/mobile/android/geckoview_example/src/main/java/org/mozilla/geckoview_example/GeckoViewActivity.java#2390 you can see that the PendingIntent in the example project is not passing a flag as is required with Android 12.

Comment 4

[Dan Baker[:dbaker]]

Attachment: Bug 1794711 - Adding flag required with Android 12.

Comment 5

[Dan Baker[:dbaker]]

Attachment: Bug 1794711 - Adding missing PendingIntent flag required with Android 12.

Depends on D163378

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to Dan Baker[:dbaker] from comment #3)

Chris, this is specific I believe to the geckoview_example project

In that case, we won't need to uplift the fix to Beta. Setting status-firefox108=wontfix.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6afebd3d000e
Adding flag required with Android 12.
https://hg.mozilla.org/integration/autoland/rev/06f8b1b11f82
Adding missing PendingIntent flag required with Android 12. r=geckoview-reviewers,owlish

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6afebd3d000e
https://hg.mozilla.org/mozilla-central/rev/06f8b1b11f82