1794757 - Save Changes and Cancel buttons are slightly clipped for the Autoplay Permissions

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: image.png

Found in

• 107.0a1 (20221011160345)

Affected versions

• 107.0a1 (20221011160345)
• 106.0 (20221010110315)
• 105.0.3 (20221007134813)

Tested platforms

• Affected platforms: macOS 12.3, Windows 10x64, Ubuntu 20.04
• Unaffected platforms: none

Steps to reproduce

1. Open about:preferences#privacy and click on Setting for Autoplay from the Permissions area.
2. Observe the Cancel and Save Changes buttons.

Expected result

• The buttons are displayed as expected.

Actual result

• The buttons are slightly cut off on the bottom side.

Regression range

• Last good revision: 5d4ec1262b2e579217133d276309e6ccdce1c28a
  17:58.41 INFO: First bad revision: b2bdddc979f368917b07162504961bc5690fff8a
  17:58.41 INFO: Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5d4ec1262b2e579217133d276309e6ccdce1c28a&tochange=b2bdddc979f368917b07162504961bc5690fff8a
  Potential regressor: bug 1784488.

Additional notes

• Attached a screenshot with the issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:dao, since you are the author of the regressor, bug 1784488, could you take a look?

For more information, please visit auto_nag documentation.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1794757 - autoplay dialog should wait for translation to finish before showing and determining size to avoid buttons being cut off, r?kpatenio

The sitePermissions code is reused, and all dialogs work OK except the autoplay one.
This is because the autoplay code adds extra content not present in the other
dialogs, and localizes it.
The SubDialog code relies on determining the size of the dialog once the
mozSubDialogReady promise resolves, which it does before fluent puts in l10n data
for the content that was just added. This patch fixes that.

It also, as a driveby, correctly pauses and resumes observing l10n attributes
in the doc when making modifications, to avoid fluent doing a second pass for
the same content.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/878883e92b09
autoplay dialog should wait for translation to finish before showing and determining size to avoid buttons being cut off, r=kpatenio

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/878883e92b09

Comment 6

[Alexandru Trif, Desktop QA [:atrif]]

Verified fixed with Firefox 108.0a1 (2022-10-27) on Windows 10x64, macOS 12 and Ubuntu 20.04. The Autoplay dialog is displayed as expected and the buttons are no longer clipped.