1794817 - Button "Translate this tab…" from Firefox Translation does not show correctly

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Fanolian]

Attachment: Firefox Translation button.png

[Tracking Requested - why for this release]: This is affecting a Firefox branded extension.

---

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:107.0) Gecko/20100101 Firefox/107.0
Build ID: 20221011160345

Steps to reproduce

1. In a new profile, install Firefox Translations.
2. Go to a page that can be translated. E.g. https://es.wikipedia.org/wiki/Wikipedia:Portada.
3. Click Translate in the notification banner.
4. See the button Translate this tab automatically as you browse on the right.

Actual result

The button does not look correct. Please refer to the attached screenshot.

Notes

The button still works.
There's another display bug for the button Options but it is caused by bug 1734220. I am filing it after this bug.

Regression

Last good Nightly: 2022-09-19
First bad Nightly: 2022-09-20
pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c8469510d1da54853ae2e018ea8d89dae14b8446&tochange=45d33d6757bae893376adc7fbbb4acf65de44dc8

Bisecting autoland builds:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=51423d631a9acaaabaa931809c54b083a63ca533&tochange=d43a9bd44619d8b122caa97a64cabf5c185b8623

This is regressed by bug 1790920.

Comment 1

[Fanolian]

Attachment: Firefox Translatoin button.png

Uploaded an outdated image.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: GitHub Pull Request

Why do we have XUL outside of mozilla-central? It's impossible to prevent this in the future if tests won't catch it.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Also, using floats with XUL is a recipe for disaster, I see the extension uses them... :(

Comment 4

[André Natal]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

Created attachment 9298256 [details] [review]
GitHub Pull Request

Why do we have XUL outside of mozilla-central? It's impossible to prevent this in the future if tests won't catch it.

Because we were forbidden from having the extension merged in m-c.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:enndeakin, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Fanolian]

Fixed in Firefox Translations 1.2.