Closed Bug 1794891 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 36416 - Change default value of video to true for getDisplayMedia calls

Categories

(Core :: WebRTC: Audio/Video, task, P4)

task

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36416 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36416
Details from upstream follow.

François Beaufort <beaufort.francois@gmail.com> wrote:

Change default value of video to true for getDisplayMedia calls

This CL makes sure the default value of video MediaStreamConstraints is false when called by getUserMedia() and true when called by
getDisplayMedia() and getDisplayMediaSet().

Spec: https://www.w3.org/TR/screen-capture/#ref-for-dom-displaymediastreamoptions-video-1

Bug: 904831
Change-Id: I28d7f3c7ffb7078108881c99361a6f4849f31081
Reviewed-on: https://chromium-review.googlesource.com/3945509
WPT-Export-Revision: 78b6c9d1d28a754f535afe4e08b4cfee310a48e8

Component: web-platform-tests → WebRTC: Audio/Video
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 56 subtests

Status Summary

Firefox

OK : 1
PASS: 49
FAIL: 7

Chrome

OK : 1
PASS: 49
FAIL: 7

Safari

OK : 1
PASS: 41
FAIL: 15

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /screen-capture/getdisplaymedia.https.html [wpt.fyi]
    • getDisplayMedia({"video":{"displaySurface":"monitor"}}) with getSettings: FAIL (Chrome: PASS, Safari: FAIL)
    • getDisplayMedia({"video":{"displaySurface":"window"}}) with getSettings: FAIL (Chrome: FAIL, Safari: FAIL)
    • getDisplayMedia({"video":{"displaySurface":"browser"}}) with getSettings: FAIL (Chrome: FAIL, Safari: FAIL)
    • displaySurface is supported: FAIL (Chrome: PASS, Safari: PASS)
    • getDisplayMedia({"selfBrowserSurface":"invalid"}) must fail with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
    • getDisplayMedia({"surfaceSwitching":"invalid"}) must fail with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
    • getDisplayMedia({"systemAudio":"invalid"}) must fail with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/84f09c8b107c [wpt PR 36416] - Change default value of video to true for getDisplayMedia calls, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.