Closed Bug 1794960 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36427 - Integrate 'color-resolving' tests with existing css-color parsing tests

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36427 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36427
Details from upstream follow.

Gordon P. Hemsley <me@gphemsley.org> wrote:

Integrate 'color-resolving' tests with existing css-color parsing tests

Following on from #36353, this integrates the color-resolving*.html tests with the existing calculated and invalid tests in the parsing/ directory. I have done very little editorializing, other than pre-calculating a lot of the test values and switching to an array-based paradigm. (This helps with extracting the tests to other formats, if necessary.) I have not put any effort into checking for redundancy with existing tests; if we were testing it twice before, we'd still be testing it twice now.

Note that this does not copy the tests to valid because the expected values are not always the same as computed and I expect that change to be slightly more controversial. (See, for example, csswg-drafts#7870.) I've left that for future work.

PR 36427 applied with additional changes from upstream: 9f736c52d047ed380482647728ed23e8f2db7179
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4d7c2aa93f10 [wpt PR 36427] - Integrate 'color-resolving' tests with existing css-color parsing tests, a=testonly https://hg.mozilla.org/integration/autoland/rev/366cc44fe18c [wpt PR 36427] - Update wpt metadata, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/4d7c2aa93f10
https://hg.mozilla.org/mozilla-central/rev/366cc44fe18c

Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.