1794987 - Font size drop-down menu overlaps the Advanced button when the Zoom text only option is selected and the Zoom is increased

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: image.png

Found in

• 107.0a1 (20221012213343)

Affected versions

• 107.0a1 (20221012213343)

Tested platforms

• Affected platforms: macOS 10.15, Windows 10x64, Ubuntu 20.04
• Unaffected platforms: none

Steps to reproduce

1. Open about:preferences in the General section and check the Zoom text only option from the Zoom section.
2. Increase zoom level to 130% or 140%.
3. Observe the Font Size dropdown menu from the Fonts section.

Expected result

• Dropdown menu is displayed as expected.

Actual result

• Font size dropdown menu overlaps the Advanced button.

Regression range

• Last good revision: b95ae2249c9b0a3a0340b2b799675c6b10821910
  First bad revision: fd57a3ea2b88fd2969fc1cf7e2c41cffff0d084d
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b95ae2249c9b0a3a0340b2b799675c6b10821910&tochange=fd57a3ea2b88fd2969fc1cf7e2c41cffff0d084d
  Potential regressor: bug 1790307.

Additional notes

• Attached a screenshot of the issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1790307, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1794987 - Simplify preferences find-in-page tooltip implementation. r=mconley,Gijs

<menulist> still uses legacy XUL layout (for reasons, I plan to fix it
but it can take a little bit).

The issue here is a poor interaction between one of the wrapping hboxes
and the xul layout. But we can simplify the code and fix the bug at the
same time, so do that.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b053921b2d1f
Simplify preferences find-in-page tooltip implementation. r=mconley,Gijs,preferences-reviewers

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b053921b2d1f

Comment 5

[Alexandru Trif, Desktop QA [:atrif]]

Verified fixed with Firefox 107.0a1 (20221017035343) on Windows 10x64, macOS 10.15 and Ubuntu 20.04. The Font size dropdown menu no longer overlaps the Advanced button when the Zoom level is increased while having the Zoom text only option checked.