Closed Bug 1795015 Opened 3 years ago Closed 2 years ago

[wpt-sync] Sync PR 36433 - Throw TypeError if constraints.video is false in getDisplayMedia calls

Categories

(Core :: WebRTC: Audio/Video, task, P4)

Product:
Core
Component:
WebRTC: Audio/Video
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36433 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36433
Details from upstream follow.

François Beaufort <beaufort.francois@gmail.com> wrote:

Throw TypeError if constraints.video is false in getDisplayMedia calls

This CL updates Chrome to match spec and other implementations. It now
throws a TypeError when constraints.video is false in getDisplayMedia
and getDisplayMediaSet calls.

Spec: https://www.w3.org/TR/screen-capture/#:~:text=If%20constraints.video%20is%20false

Bug: 904831
Change-Id: I0a80a6f1ad9f51b8a905e474f8c57a6611e2c593
Reviewed-on: https://chromium-review.googlesource.com/3948708
WPT-Export-Revision: d4b124ca91fd80915893af06a6667df6e8b2b075

PR 36433 applied with additional changes from upstream: a9e78f9de08d0e0decf383d2f14b4efe7e5f7a05, f928bdb74892727cf89a4ff07ce3af5dbd177ca3
Component: web-platform-tests → WebRTC: Audio/Video
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 57 subtests

Status Summary

Firefox

OK : 1
PASS: 50
FAIL: 7

Chrome

OK : 1
PASS: 50
FAIL: 7

Safari

OK : 1
PASS: 42
FAIL: 15

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /screen-capture/getdisplaymedia.https.html [wpt.fyi]
    • getDisplayMedia({"video":{"displaySurface":"monitor"}}) with getSettings: FAIL (Chrome: PASS, Safari: FAIL)
    • getDisplayMedia({"video":{"displaySurface":"window"}}) with getSettings: FAIL (Chrome: FAIL, Safari: FAIL)
    • getDisplayMedia({"video":{"displaySurface":"browser"}}) with getSettings: FAIL (Chrome: FAIL, Safari: FAIL)
    • displaySurface is supported: FAIL (Chrome: PASS, Safari: PASS)
    • getDisplayMedia({"selfBrowserSurface":"invalid"}) must fail with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
    • getDisplayMedia({"surfaceSwitching":"invalid"}) must fail with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
    • getDisplayMedia({"systemAudio":"invalid"}) must fail with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ede8f1177e6c [wpt PR 36433] - Throw TypeError if constraints.video is false in getDisplayMedia calls, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ede8f1177e6c

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.