1795086 - [wpt-sync] Sync PR 36166 - Initialize cache_state at navigation timing instantiation

Status: RESOLVED FIXED

(Core :: DOM: Performance APIs, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36166 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36166
Details from upstream follow.

Hao Liu <[e-mail]> wrote:

Initialize cache_state at navigation timing instantiation

Currently the transfer size of navigation timing entries is not being properly set based on the entry's cache state, always being set as if the resource was fetched from the network, even when cached. This is a result of the fact that the transferSize depends on PerformanceResourceTiming::cache_state_, which is not initialized for navigation timing, and hence always takes the default value. This CL fixes that by passing in the right cache state value when navigation timing entries are created.

Bug: 1262896
Change-Id: I290d97254bed846331549a3ff96c7c3e6502230d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842449
Reviewed-by: Yoav Weiss \<[e-mail]>
Reviewed-by: Bo Liu \<[e-mail]>
Commit-Queue: Hao Liu \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1058724}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c9cd7d99db6e4393704e66eaa83a5f4e5f06840

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL : 2

Chrome

OK : 2
FAIL : 2

Safari

OK : 1
FAIL : 1
TIMEOUT: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /navigation-timing/prefetch-transfer-size-executor.html [wpt.fyi]
  • Navigation timing transfer size for a prefetched navigation should be 0.: FAIL (Chrome: FAIL, Safari: FAIL)
• /navigation-timing/prefetch-transfer-size-iframe.html [wpt.fyi]
  • Navigation timing transfer size for a prefetched navigation should be 0.: FAIL (Chrome: FAIL, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/047c93ea434b
[wpt PR 36166] - Initialize cache_state at navigation timing instantiation, a=testonly
https://hg.mozilla.org/integration/autoland/rev/7d6608d13b70
[wpt PR 36166] - Update wpt metadata, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/047c93ea434b
https://hg.mozilla.org/mozilla-central/rev/7d6608d13b70