Closed Bug 1795115 Opened 3 years ago Closed 2 years ago

BrowserMenuImageTextCheckboxButton item a11y

Categories

(Firefox for Android :: Bookmarks, defect)

Product:
Firefox for Android
Component:
Bookmarks
Platform:
All
Android
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: csadilek, Unassigned)

Details

From github: https://github.com/mozilla-mobile/android-components/issues/11958.

See https://github.com/mozilla-mobile/fenix/issues/24560

For the Bookmarks Menu item with integrated Add/Edit button the BrowserMenuItem called BrowserMenuImageTextCheckboxButton is used (introduced in #9943).

However there is an accessibility bug, regarding the size of it's clickable areas.

If you click a little off the checkbox area (namely on the right, top or bottom of the checkbox) then the parent bookmarks menu item is clicked.
That behavior is definitely not intended.

If users want to open the bookmarks list they will only click on the left where the label "Bookmarks" is and never on the right where the "Add/Edit" button is located.

<p>
<img src="https://user-images.githubusercontent.com/64743731/161560722-4946a6ef-cef6-4f52-b3ad-f17295c3e6e5.jpg" width="45%" title="checkbox is clicked"/>
<img src="https://user-images.githubusercontent.com/64743731/161560877-34b1dd44-124d-4e5f-9728-695316f4557c.jpg" width="45%" title="menu item is clicked"/>
</p>

Solution would be to extent the clickable area of the checkbox to the top, bottom and outer right end of its parent element.
Therefore, also paddingEnd coming from @style/Mozac.Browser.Menu.Item.Container has to be removed for the mozac_browser_menu_item_image_text_checkbox_button layout.

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(cpeterson)
Severity: -- → S3
Summary: [Bug]: [a11y] BrowserMenuImageTextCheckboxButton item → BrowserMenuImageTextCheckboxButton item a11y
Flags: needinfo?(cpeterson)

Could we verify if this is still occurring?

Flags: qe-verify+

I was not able to reproduce this issue on Nightly 121.0a1 from 10/31, Beta 120.0b4, nor on RC 119.0.1 build 1.
Tested with the following devices:

  • HTC 10 (Android 8),
  • Oppo Find N2 Flip (Android 13),
  • Google Pixel 6 (Android 14), and
  • Lenovo tab M10 (Android 10).

I'll close this ticket as WORKSFORME.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: qe-verify+
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.