1795116 - Support specifying tiltX/tiltY/twist on synthesized touch event

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement)

Description

[Edgar Chen [:edgar]]

Now we don't support synthesizing touch event with specified tiltX, tiltY and twist value. It should not hard to support that, we just need to add a way to pass those value to https://searchfox.org/mozilla-central/rev/76ccfc801e6b736c844cde3fddeab7a748fc8515/dom/base/nsDOMWindowUtils.cpp#908-909.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Hi Edgar, thank you for filing this bug. Do you think that this new feature could be implemented in the next weeks or months? If you or someone else doesn't have the time maybe we could find someone else or mentor the bug? We would be kinda interested in. Thanks!

Comment 2

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=634c764a5c8fa48a62a9a6856126bd981c2c78d0

Comment 3

[Edgar Chen [:edgar]]

Attachment: Bug 1795116 - Support specifying tiltX/tiltY/twist on synthesized touch event; r?smaug

Comment 4

[Edgar Chen [:edgar]]

Hi Henrik, could you help to try whether this patch works for geckodrvier? Thanks!

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Edgar Chen [:edgar] from comment #4)

Hi Henrik, could you help to try whether this patch works for geckodrvier? Thanks!

Absolutely! I've triggered some opt builds via the try build on Phabricator and will run some tests tomorrow:
https://treeherder.mozilla.org/jobs?repo=try&revision=2e404414bf238804cf69e1a121cd433b1e0e4877&searchStr=build%2Copt

Thanks a lot for working on it Edgar!!

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I have asked James to also have a look given that he implemented the related code in Marionette. He replied on the Phabricator revision.

Comment 7

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=9ed4403c603c4b6d117ba9200a4271f137a899ee

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d00302ab3940
Support specifying tiltX/tiltY/twist on synthesized touch event; r=webdriver-reviewers,smaug,whimboo

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d00302ab3940