Closed Bug 1795172 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36447 - Disallow culled inlines in repeated content.

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36447 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36447
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Disallow culled inlines in repeated content.

We cannot represent repeated culled inlines correctly, if a culled
LayoutInline has another culled LayoutInline child. We'd jump to the
next fragmentainer prematurely when processing the outermost
LayoutInline (because it's repeated in the next fragmentainer), before
processing the LayoutInline child.

Also SetIsInsideRepeatableContent() on the constraint space when
handling repeated fixed-positioned content, just like we already do for
repeated table headers and footers in the table layout algorithm. This
was an oversight, but didn't really make much of a difference, until
now, that non-table code actually checks IsInsideRepeatableContent().

Bug: 1373172
Change-Id: I3ba988757711b886bbb29d76da5fad53688c3155

Reviewed-on: https://chromium-review.googlesource.com/3952683
WPT-Export-Revision: 7091c1f79960249bdd2fd25bc419705144b98c4a

Component: web-platform-tests → Layout
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2d54cfa1d788 [wpt PR 36447] - Disallow culled inlines in repeated content., a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.