1795177 - OSX AArch64 code not getting indexed

Status: RESOLVED FIXED

(Webtools :: Searchfox, defect)

Description

[Andrew McCreight [:mccr8]]

This piece of code is only built when both XP_MACOSX and aarch64 are defined. None of the code in that block seems to be linkified. For instance, this is the only caller of nsMacUtilsImpl::GetArchitecturesForBundle(), so if you search for that symbol no uses show up. I'm not sure how much code like this there is.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Thanks for filing this! I think someone needs to:

• Create a macosx64-aarch64-searchfox/debug job like the existing macosx64-searchfox/debug job, but since there doesn't seem to be a bare macosx64-aarch64/debug job we'd crib from macosx64-aarch64-noopt/debug
• Add that to the list that expresses the searchfox indexing task's dependencies in target_tasks.py for the searchfox-index cron job.
• Add the platform everywhere we currently have macosx64 in mozsearch-mozilla. I think it's probably okay that one platform would be a suffix/prefix of the other, but it's probably worth double-checking that the logic won't freak out about that.

This is definitely a great opportunity for someone looking to contribute to searchfox, so I am going to proactively avoid working this bug.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1795177 - Add macosx64-aarch64-searchfox/debug job. r?#releng-reviewers!

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: GitHub Pull Request

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: GitHub Pull Request

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/997e6608406a
Add macosx64-aarch64-searchfox/debug job. r=releng-reviewers,taskgraph-reviewers,bhearsum

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/997e6608406a