1795224 - The Profile Manager is wider after the latest update to Nightly 107

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Simona Badau, Desktop QA]

Attachment: Screenshot with the issue

Found in

• Nightly 107.0a1

Affected versions

• Nightly 107.0a1

Tested platforms

• Affected platforms: Ubuntu 20.04, macOS 11.6, and Windows 10

Steps to reproduce

1. Install Firefox
2. Open the Profile Manager and observe it.

Expected result

• The profile manager is properly displayed.

Actual result

• The window of the profile manager is wider. Please see the screenshot.

Regression range

• Last good revision: e63a07f26954b74c53db790288de6cdbc08280cb
• First bad revision: 8390e1d55a65db3a7605d49b37a226df55001344
• Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e63a07f26954b74c53db790288de6cdbc08280cb&tochange=8390e1d55a65db3a7605d49b37a226df55001344
• Potentially regressed by: bug 1794969

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1794969, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[Fanolian]

Attachment: Profile Manager on Windows 10.png

Bottom is cut off on Windows 10.
Windows from Create/Rename/Delete Profile are not affected.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1795224 - Unify profile selection css. r=Gijs

It's the same across platforms. The box#managebuttons selector never
matches (the element is a vbox), so remove that while at it.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1795224 - Use flexbox on the profile window. r=Gijs

No behavior change, but while at it let's do this.

Depends on D159389

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1795224 - Size profile selection dialog to min-size. r=Gijs

Like it used to be (though resizing it didn't work before and does now).

Depends on D159390

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c76d755cd34
Unify profile selection css. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/5bf2d21ead59
Use flexbox on the profile window. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/c437eb557374
Size profile selection dialog to min-size. r=Gijs

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0c76d755cd34
https://hg.mozilla.org/mozilla-central/rev/5bf2d21ead59
https://hg.mozilla.org/mozilla-central/rev/c437eb557374

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: Beta patch.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1794969
[User impact if declined]: comment 0
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: N/A
[Needs manual test from QE? If yes, steps to reproduce]: comment 0
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: Partially backs out bug 1794969.
[String changes made/needed]: none

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9299225 [details] [diff] [review]
Beta patch.

Approved for 107.0b3.

Comment 11

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1b8d415cb8c3

Comment 12

[Simona Badau, Desktop QA]

Verified as fixed on the latest Nightly 108.0a1 and Firefox 107.0b3 - tested on Windows 7, Windows 10, Ubuntu 20.04, and macOS 11.7.