1795232 - Checked menuitem in menulist popups shifted in in-content pages

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[Richard Marti (:Paenglab)]

Attachment: menulist-popup.png

After bug 1794407 the checked menuitems in menulist popups in in-content pages like the prefs are shifted to the right.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1794407

:emilio, since you are the author of the regressor, bug 1794407, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1795232 - Remove spacing from in-content menuitem checkmarks. r=mstange,jfkthame

This preserves the behavior from before the regressing bug on in-content
menulists like about:preferences.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9298671 [details]
Bug 1795232 - Remove spacing from in-content menuitem checkmarks. r=mstange,jfkthame

Beta/Release Uplift Approval Request

• User impact if declined: Relatively straight-forward CSS fix.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial macOS-only CSS selector change.
• String changes made/needed: none
• Is Android affected?: No

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15fa8d389813
Remove spacing from in-content menuitem checkmarks. r=desktop-theme-reviewers,dao

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/15fa8d389813

Comment 6

[Donal Meehan [:dmeehan]]

Comment on attachment 9298671 [details]
Bug 1795232 - Remove spacing from in-content menuitem checkmarks. r=mstange,jfkthame

Approved for 107.0b2.

Comment 7

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e5c8f27c221a

Comment 8

[Alin Ilea, Desktop Test Engineering]

Reproduced the issue in Nightly 107.0a1 (2022-10-14) using macOS 12.
Verified - Fixed in the latest Nightly 108.0a1 (2022-10-19) and Beta 107.0b2, on macOS 12 and macOS 10.15.6