1795288 - Add DISMISS telemetry to feature callouts so their telemetry is more consistent with Spotlight's

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Shane Hughes [:aminomancer]]

We noticed working on bug 1787532 that Feature Callouts don't send complete telemetry when dismissing — no DISMISS ping, just a ping for the triggering click. The action can be looked up by finding the message, but we could just send both pings. Bug 1787532 adds a new way to dismiss the callout, so we should try doing this in a way that it's along that codepath too (e.g. updating _endTour).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:tspurway, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Shane Hughes [:aminomancer]]

Attachment: Bug 1795288 - Feature Callouts: add dismiss telemetry. r=mviar

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:aminomancer, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 4

[Meg Viar [:mviar]]

I checked with :aminomancer and this patch can land once updated to reflect the latest changes to Firefox View Feature Callout tests.

Comment 5

[Shane Hughes [:aminomancer]]

Attachment: Bug 1795288 - Feature Callouts: add dismiss telemetry. r=mviar

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c7d818e044a
Feature Callouts: add dismiss telemetry. r=mviar

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8c7d818e044a