Closed
Bug 1795306
Opened 2 years ago
Closed 2 years ago
Create a reusable moz-toggle element
Categories
(Toolkit :: UI Widgets, enhancement)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
108 Branch
Tracking | Status | |
---|---|---|
firefox108 | --- | fixed |
People
(Reporter: hjones, Assigned: hjones)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Currently we have at least four different toggle implementations/styles in different places in Firefox desktop. We want to create a single lit based reusable toggle element to help us standardize our implementations and reduce code duplication.
Assignee | ||
Updated•2 years ago
|
Blocks: reusable-components
Assignee | ||
Comment 1•2 years ago
|
||
This patch adds an fx-toggle
widget along with associated stories and some basic tests.
Some random thoughts/notes:
- Some of the colors are a bit off from the figma specs since we're still using in-content variables for now
- The tests are pretty basic, and possibly a little redundant
- As a follow up I'm going to experiment with creating an
fx-label
element and will see if it's possible to useElementInternals
to keep the association between the input and the label - As another follow up I'm going to try to expand on how we handle documentation of components in Storybook (i.e. can we pull in JSDoc annotations or add markdown support)
Assignee | ||
Comment 2•2 years ago
|
||
Moving the test to a separate patch so that we can land the toggle implementation + storybook work with the dev vendoring of lit.
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5b3867f9fc9d create a reusable fx-toggle component r=mstriemer
Comment 4•2 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox108:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
Assignee | ||
Updated•2 years ago
|
Blocks: moz-toggle
Assignee | ||
Updated•2 years ago
|
No longer blocks: reusable-components
Updated•1 year ago
|
Attachment #9301803 -
Attachment description: Bug 1795306 - add a test for fx-toggle r=mstriemer → Bug 1795306 - add a test for moz-toggle r=mstriemer
Pushed by hjones@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4f47f730e4f6 add a test for moz-toggle r=mstriemer
Comment 6•1 year ago
|
||
bugherder |
Updated•11 months ago
|
Summary: Create a reusable fx-toggle element → Create a reusable moz-toggle element
You need to log in
before you can comment on or make changes to this bug.
Description
•