1795324 - Stop using deprecated FSFindFolder in crashreporter_osx.mm

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, task)

Comment 1

[Robert Longson [:longsonr]]

Attachment: Bug 1795324 - replace deprecated FSFindFolder in crashreporter r=mstange

Comment 2

[Robert Longson [:longsonr]]

The following command line program shows that the output is the same...

#import <Foundation/Foundation.h>

int main(int argc, const char * argv[]) {
  @autoreleasepool {
    {
      FSRef foundRef;
      OSErr err = FSFindFolder(kUserDomain, kApplicationSupportFolderType, kCreateFolder, &foundRef);
      if (err != noErr) return false;
      
      unsigned char path[PATH_MAX];
      FSRefMakePath(&foundRef, path, sizeof(path));
      NSString* destPath = [NSString stringWithUTF8String:(char *)path];
      // insert code here...
      NSLog(@"%@", destPath);
    }
    {
      NSArray *paths = NSSearchPathForDirectoriesInDomains(NSApplicationSupportDirectory, NSUserDomainMask, YES);
      NSString *destPath = [paths firstObject];
      NSLog(@"%@", destPath);
    }
  }
  return 0;
}

2022-10-14 16:16:36.475034+0100 TestBed[39364:6455661] /Users/<user name>/Library/Application Support
2022-10-14 16:16:36.475837+0100 TestBed[39364:6455661] /Users/<user name>/Library/Application Support
Program ended with exit code: 0

Comment 3

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=584af0250249fd2d4c1903d6e41ecbeec65570b5

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cba1054f7796
replace deprecated FSFindFolder in crashreporter r=mstange

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/cba1054f7796