1795351 - ReaderView page action is visible in Custom Tabs

Status: RESOLVED WORKSFORME

(Firefox for Android :: WebExtensions, defect, P3)

Description

[Christian Sadilek [:csadilek]]

From github: https://github.com/mozilla-mobile/android-components/issues/2897.

We should find a way to make this optional so that we don't add to all Custom Tab clients if they don't want that feature enabled in a CT session.

cc: @csadilek

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Zac McKenney [:zmckenney]]

This seems like a product question for whether we want the option to prevent readerview in custom tabs.

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

This seems like a technical decision. We don't show any reader mode UI in custom tabs but are paying the page load perf costs of parsing the page for reader mode. See bug 1770985 and dependent bugs for details.

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #3)

We don't show any reader mode UI in custom tabs but are paying the page load perf costs of parsing the page for reader mode. See bug 1770985 and dependent bugs for details.

IIUC, the original GitHub issue says we are showing the reader mode UI ("ReaderView page action is visible in Custom Tabs") and suggests we make it optional ("We should find a way to make this optional so that we don't add to all Custom Tab clients").

What's a convenient app and STR for testing custom tabs?

If we're already hiding the reader mode UI in custom tabs, then we could morph this bug to be about removing the unnecessary reader mode parsing.

Comment 5

[Jonathan Almeida [:jonalmeida]]

Closing as worksforme - this was a bug a long time ago when we were showing the ReaderView icon in the toolbar. This seems to have been fixed in a separate issue (unknown).

(In reply to Chris Peterson [:cpeterson] from comment #4)

What's a convenient app and STR for testing custom tabs?

Gmail usually works best.