1795372 - FuncScope should automatically keepalive mNotLost

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

Right now we have to explicitly keepalive mNotLost for functions that need it.
It's safer if we just keepalive unconditionally, as long as the perf isn't too bad. (it shouldn't be)
If we need a less-safe perf carve-out, it should be a safety-opt-out, rather than safety-opt-in like now.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1795372 - Keepalive mNotLost within FuncScope.

Also remove unused FuncScopeId.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1795372 - Remove redundant keepalives.

Now that FuncScope keepalives mNotLost, individual functions don't need
to.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/143f35b82018
Keepalive mNotLost within FuncScope. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/bdd24cc1c1fd
Remove redundant keepalives. r=gfx-reviewers,lsalzman

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/143f35b82018
https://hg.mozilla.org/mozilla-central/rev/bdd24cc1c1fd

Comment 5

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 9298689 [details]
Bug 1795372 - Keepalive mNotLost within FuncScope.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Prevent a class of sec and/or stability issues that is fixed on Release.
• User impact if declined: Leaves in a class of sec and/or stability issues that is fixed on Release.
• Fix Landed on Version: 107
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Lots of tests

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9298689 [details]
Bug 1795372 - Keepalive mNotLost within FuncScope.

Approved for 102.6esr.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/76cc8c96f4a8
https://hg.mozilla.org/releases/mozilla-esr102/rev/7020896e8c7c