Closed Bug 179538 Opened 21 years ago Closed 18 years ago

[ps] Default solaris print command should call "lp"

Categories

(Core :: Printing: Output, defect, P4)

Sun
Solaris
defect

Tracking

()

RESOLVED FIXED
Future

People

(Reporter: gonufer, Assigned: kherron+mozilla)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.3a) Gecko/20021110
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.3a) Gecko/20021110

lpr is part of the optional UCB/Solaris 1.x compatability packages that are not
guaranteed to be installed on all SunOS 5.x systems.  Mozilla printing does not
work by default on systems without those optional compatability packages
installed.  Note that the packages are for compatability with an OS that hasn't
shipped for many years.


Reproducible: Always

Steps to Reproduce:
1. try to print anything from mozilla
2.
3.

Actual Results:  
Nothing.


Expected Results:  
Something being printed.
This is NOT a fix, it's just the changes I made for my SunOS 5 builds.	It will
break systems that use lpr and do not have lp.
Mhhh, the quiz is how to fix that ?
The default is set via unix.js - we would need a way to do somelike like this in
JavaScript:
-- snip --
#ifdef __sun
#define DEFINE_DEFAULT_SPOOLER "/usr/bin/lp"
#else
#define DEFINE_DEFAULT_SPOOLER "/usr/bin/lpr"
#endif
-- snip --

Any ideas ?
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: SunOS → Solaris
Summary: lpr is not guaranteed to exist on SunOS 5.x systems, lp is guaranteed to exist and should be used instead → [ps] lpr is not guaranteed to exist on SunOS 5.x systems, lp is guaranteed to exist and should be used instead
Well, a working workaround would be to use Xprint instead ("Xprt" on Solaris 2.x
uses /usr/bin/lp since eternity :) ...
The real pseudo code should look more like this:

#ifdef __sysv
#define DEFINE_DEFAULT_SPOOLER "lp"
#else
#define DEFINE_DEFAULT_SPOOLER "lpr"
#endif

since SunOS 4.x systems, if anyone were to be foolish enough to port mozilla to
them, use lpr and should also satisfy the __sun condition.  Note that the
spooler arguments also change.
Greg Onufer wrote:
> The real pseudo code should look more like this:
[snip]

OK, but that still does not solve my main headache:
How to get this implemented in JavaScript ?
Priority: -- → P4
Target Milestone: --- → Future
This should be pretty easy to fix now. Since this bug was written, all of the
default prefs have been moved into libpref/src/init/all.js, which goes through a
preprocessing phase that specifically supports per-OS defaults.
Assignee: rods → printing
QA Contact: sujay
Summary: [ps] lpr is not guaranteed to exist on SunOS 5.x systems, lp is guaranteed to exist and should be used instead → [ps] Default solaris print command should call "lp"
This sets alternate defaults for the prefs "print.print_command" and
"print.postscript.print_command" for solaris. I've tested this with a fresh
profile; the new print command shows up in the print dialog, and I can still
print.

There's no good reason to have two separate prefs for this. We should probably
standardize on "print.postscript.print_command". But that's an issue for
another day.

Does a patch like this require sr?
Assignee: printing → kherron+mozilla
Attachment #105858 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #177016 - Flags: review?(alecf)
Comment on attachment 177016 [details] [diff] [review]
Different print_command prefs for solaris

huh? I don't remember #ifdef's working in all.js, unless we're now
pre-processing it. This isn't C.
Attachment #177016 - Flags: review?(alecf) → superreview-
Comment on attachment 177016 [details] [diff] [review]
Different print_command prefs for solaris

sorry, my bad on the preprocessing..
Attachment #177016 - Flags: superreview- → superreview+
Comment on attachment 177016 [details] [diff] [review]
Different print_command prefs for solaris

Requesting approval to check in. This just changes a couple of default prefs
for solaris.
Attachment #177016 - Flags: approval1.8b2?
Comment on attachment 177016 [details] [diff] [review]
Different print_command prefs for solaris

a=asa
Attachment #177016 - Flags: approval1.8b2? → approval1.8b2+
Checked in. Resolving FIXED.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.