Open Bug 1795417 Opened 3 years ago Updated 3 years ago

Reconsider Observer Pattern for Top Sites

Categories

(Firefox for Android :: Top Sites, task)

Product:
Firefox for Android
Component:
Top Sites
Platform:
All
Android
Type:
task

Tracking

()

People

(Reporter: csadilek, Unassigned)

Details

From github: https://github.com/mozilla-mobile/android-components/issues/9477.

We use an Observer pattern for knowing when the Top Sites DB has been updated (one example) and this doesn't follow the rest of the Flow/LiveData patterns we use with Room DBs.

Is there a good reason we are using these here? I looked around and it seems like this could be refactored to use a Flow return type which would then be collected by TopSitePresenter and would be cleaner/more consistent.

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(cpeterson)
Severity: -- → N/A
Type: defect → task
Flags: needinfo?(cpeterson)
You need to log in before you can comment on or make changes to this bug.