1795779 - AutoProfilerImagePaintMarker ctor always calls TimeStamp::Now()

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

TimeStamp::Now() is rather slow and the call shows up in the performance profiles for example when running 'leaves' part of MotionMark

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1795779. Don't call TimeStamp::Now for the profiler every time an image is drawn if the profiler isn't active. r?smaug

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6f757b147b5
Don't call TimeStamp::Now for the profiler every time an image is drawn if the profiler isn't active. r=smaug

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1704103

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c6f757b147b5

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:tnikkel, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Timothy Nikkel (:tnikkel)]

Comment on attachment 9298932 [details]
Bug 1795779. Don't call TimeStamp::Now for the profiler every time an image is drawn if the profiler isn't active. r?smaug

Beta/Release Uplift Approval Request

• User impact if declined: small perf fix
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): small change to only make calls needed by the profiler when it is active
• String changes made/needed:
• Is Android affected?: Yes

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9298932 [details]
Bug 1795779. Don't call TimeStamp::Now for the profiler every time an image is drawn if the profiler isn't active. r?smaug

Approved for 107.0b3.

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9362e3956827