I would like to expose the number of signed items a jar has via the nsIJar interface. This is so that I can verify that a jar does not have any missing files.
Comment on attachment 105883 [details] [diff] [review] patch v.1 Your mTotalItemsInManifest counter will be incremented on manifest entries with no name, and on duplicate entries. That may be what you want. If not, you probably want to move the increment below the if-clauses that set JAR_INVALID, then test for JAR_INVALID before incrementing. Aside from that, r=mstoltz.
Attachment #105883 - Flags: review+
that is exactly what I want. Thanks for the quick review mitch!
Comment on attachment 105883 [details] [diff] [review] patch v.1 I believe all this is rolled into the big signed-xpi patch I'm reviewing, but sr=dveditz here anyway
Attachment #105883 - Flags: superreview? → superreview+
Checking in nsIJAR.idl; /cvsroot/mozilla/modules/libjar/nsIJAR.idl,v <-- nsIJAR.idl new revision: 1.10; previous revision: 1.9 done Checking in nsJAR.cpp; /cvsroot/mozilla/modules/libjar/nsJAR.cpp,v <-- nsJAR.cpp new revision: 1.99; previous revision: 1.98 done Checking in nsJAR.h; /cvsroot/mozilla/modules/libjar/nsJAR.h,v <-- nsJAR.h new revision: 1.42; previous revision: 1.41 Checking in objs.mk; /cvsroot/mozilla/modules/libjar/objs.mk,v <-- objs.mk new revision: 1.4; previous revision: 1.3 done
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.