1795797 - CalDAV doesn't sync all items if the server says another request should be made

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

If CalDavWebDavSyncHandler encounters a 507 response, meaning the server has more items than it is willing to return in one request, it sets a flag and then does nothing about it. It decides it hasn't seen any items that weren't in the first request and deletes them.

Comment 1

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: Bug 1795797 - If a CalDAV sync response says there are more items, request the items. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6d4e7a383e6f
If a CalDAV sync response says there are more items, request the items. r=mkmelin

Comment 3

[Rob Lemley [:rjl]]

Comment on attachment 9298931 [details]
Bug 1795797 - If a CalDAV sync response says there are more items, request the items. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta.

Comment 4

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: Bug 1795797 - Test CalDAV with multiple requests needed to collect all items. r=#thunderbird-reviewers

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 107.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/8b303f5a6ea4

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/731ffefef2d3
Test CalDAV with multiple requests needed to collect all items. r=mkmelin

Comment 7

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Comment on attachment 9298960 [details]
Bug 1795797 - Test CalDAV with multiple requests needed to collect all items. r=#thunderbird-reviewers

[Approval Request Comment]
A test for the already uplifted patch.

Comment 8

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: Bug 1795797 - Await CalDAVServer.putItemInternal wherever it is called. r=#thunderbird-reviewers

I missed one of these in a review comment. It turns out there are many calls which do not await, although it doesn't appear to make any difference.

Comment 9

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Comment on attachment 9298931 [details]
Bug 1795797 - If a CalDAV sync response says there are more items, request the items. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: items might disappear if a full sync happens, like we're triggering with bug 1792923
Testing completed (on c-c, etc.): in beta 1
Risk to taking this patch (and alternatives if risky): should be low

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9298960 [details]
Bug 1795797 - Test CalDAV with multiple requests needed to collect all items. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9298931 [details]
Bug 1795797 - If a CalDAV sync response says there are more items, request the items. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Perhaps the test patch should also be applied? This needs to be applied before bug 1792923 (not 1793323).

Comment 12

[Rob Lemley [:rjl]]

Reopening so that D159823 can land on c-c.
D159823 also needs to make it to beta and 102.

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 102.4.1:
https://hg.mozilla.org/releases/comm-esr102/rev/f6db10f205cf
https://hg.mozilla.org/releases/comm-esr102/rev/e572bc3cfa07

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 107.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/9c898b53ff35

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/edb87d646ad2
Await CalDAVServer.putItemInternal wherever it is called. r=mkmelin

Comment 16

[Rob Lemley [:rjl]]

Comment on attachment 9299417 [details]
Bug 1795797 - Await CalDAVServer.putItemInternal wherever it is called. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: N/A
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Low risk. It's all test code and it just adding await to some places that didn't have it. The rest of this bug has been uplifted, this patch should go too.

Comment 17

[Wayne Mery (:wsmwk)]

Comment on attachment 9299417 [details]
Bug 1795797 - Await CalDAVServer.putItemInternal wherever it is called. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta
Approved for esr102

[Triage Comment]

Comment 18

[Daniel Darnell [:dandarnell]]

Thunderbird 107.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/80f3cb9db915

Comment 19

[Rob Lemley [:rjl]]

Thunderbird 102.4.2:
https://hg.mozilla.org/releases/comm-esr102/rev/297f509ebef7