1795808 - [HCM] Primary subtitles on all Onboarding screens to use CanvasText in HCM

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P2)

Description

[Anna Yeddi [:ayeddi]]

Attachment: 2022-10-17_Subtitle-color-HCM-on-Win.png

STR:

1. Activate system High Contrast Mode (masOS: Settings > Accessibility > Display > Display > Increase Contrast, WinOS: Settings > Accessibility > Contrast Themes > (i.e. Night Sky) > Apply)
2. Open the Firefox browser
3. Open the Browser Console and enter:
   Cc["@mozilla.org/browser/browserglue;1"].getService().wrappedJSObject._showUpgradeDialog()
4. Observe color of the subtitle text

Expected:

Color used by the subtitle respects the static text color from the OS color palette (uses CanvasText color)

Actual:

Color used by the subtitle remains low contrast (gray on dark themes), it is not using the static text color from the OS color palette (uses hardcoded #CFCFD8 color on the dark theme).

Version: Firefox Nightly 107.0a1 (2022-10-17) (64-bit) on macOS 12.6 and Windows OS 11.

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: 2022-10-17_Subtitle-color-HCM-on-Mac.png

MacOS screenshot with code snippet

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:tspurway, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Shane Hughes [:aminomancer]]

Attachment: Bug 1795808 - HCM: Don't use static colors in about:welcome. r=pdahiya

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/221b872e61bb
HCM: Don't use static colors in about:welcome. r=hanna_a

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/221b872e61bb

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I tried reproducing this issue on Windows 11 using HCM(Night Sky) and the STR from Comment 0 without success. After introducing the command line in the Console I get the following error:

Uncaught ReferenceError: Cc is not defined
<anonymous> debugger eval code:1

Are there any prefs I need to tweak in about:config to properly reproduce and verify this fix, or any steps whatsoever I might've missed? I tried with devtools.chrome.enabled to true but it didn't help.
Thank you.

Comment 7

[Shane Hughes [:aminomancer]]

You have to enter the JS in the Browser Console (ctrl+alt+shift+i) which requires devtools.debugger.remote-enabled as well

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Thank you!
Reproduced with a 2022-10-17 Nightly build on Windows 11( with HCM enabled). Verified as fixed on Firefox 108.0b5(build ID: 20221122190120) and Nightly 109.0a1(build ID: 20221124093251) on Windows 11, Ubuntu 22, macOS 12.