1795906 - Unified build failure

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect, P3)

Description

[[:fabrice] Fabrice Desré]

On some build machines I see unified build failures due to a missing include:

08:09:07  0:23.57 In file included from UnifiedBindings21.cpp:2:
08:09:07  0:23.57 /home/kaios-ci/Docker/kai/master/objdir-gecko/dom/bindings/PushSubscriptionOptionsBinding.cpp:214:10: error: use of undeclared identifier 'ServiceWorkerVisible'
08:09:07  0:23.57   return ServiceWorkerVisible(aCx, aObj);

Happy to test a fix if someone knows where to include ServiceWorker.h

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

I think this comes from
https://bugzilla.mozilla.org/show_bug.cgi?id=1776109

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Oh, this is a bit tricky as PushSubscriptionOptions does not directly include ServiceWorker and thus does not include ServiceWorker.h.

Can you try including bool ServiceWorkerVisible(JSContext* aCx, JSObject* aGlobal); to PushSubscriptionOptions.h and see if it works?

Comment 3

[[:fabrice] Fabrice Desré]

(In reply to Kagami :saschanaz from comment #2)

Oh, this is a bit tricky as PushSubscriptionOptions does not directly include ServiceWorker and thus does not include ServiceWorker.h.

Can you try including bool ServiceWorkerVisible(JSContext* aCx, JSObject* aGlobal); to PushSubscriptionOptions.h and see if it works?

Hi, yes I can confirm that this fix works.

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1795906 - Fix unified build failure from PushSubscriptionOptions r=fabrice

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c45d68ec4862
Fix unified build failure from PushSubscriptionOptions r=fabrice

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c45d68ec4862