1795926 - [Automated review] Code review bot complains about thread name change

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Ray Kraesig [:rkraesig]]

Phabricator URL: https://phabricator.services.mozilla.com/D159560

The code review bot complains here about a thread's name being unrecognized -- apparently because it isn't picking up the change to build/clang-plugin/ThreadAllows.txt in that patch which provides the new name.

Comment 1

[Mike Hommey [:glandium]]

This is happening because the file is not in https://searchfox.org/mozilla-central/rev/7b5c93295ea5071d3cc5b3ac21c6e8e654f69e1b/taskcluster/ci/toolchain/clang-tidy.yml#16-23

Comment 2

[Andi [:andi]]

Attachment: Bug 1795926 - add `ThreadAllows.txt` to the build trigger mechanism of `clang-tidy`. r=glandium

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a0816f464a8
add `ThreadAllows.txt` to the build trigger mechanism of `clang-tidy`. r=glandium

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0a0816f464a8

Comment 5

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1795926 - add `*.txt` to the build trigger mechanism of `clang-tidy` r=glandium,andi

Foillowup to D159671.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34bb52773e29
add `*.txt` to the build trigger mechanism of `clang-tidy`  r=glandium

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/34bb52773e29