1795949 - Fix IllegalStateException crash when returning to Firefox while a <select> is open

Status: RESOLVED FIXED

(Firefox for Android :: General, defect, P1)

Description

[Alexandru Putanu [:aputanu]]

To fix https://github.com/mozilla-mobile/fenix/issues/27433 we should only dismiss the ChoiceDialogFragment when it is attached.

Comment 1

[Alexandru Putanu [:aputanu]]

See https://github.com/mozilla-mobile/android-components/pull/12973

Comment 2

[BMO Automation]

Attachment: GitHub Pull Request

Comment 3

[Chris Peterson [:cpeterson]]

Alexandru, should this exception fix be uplifted to Fenix 107 Beta?

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Do we understand why this crash was not caught by our crash reporter?

Comment 5

[Alexandru Putanu [:aputanu]]

I think we should uplift the fix to 107. In the Fenix issue, the crash was reported on 106. The PR that introduced this crash landed in AC on August 8th.

Comment 6

[Donal Meehan [:dmeehan]]

I see this PR was merged into main.
Do we still plan on approving the uplift for 107?

Comment 7

[Alexandru Putanu [:aputanu]]

Sure, I'll create the backport PR and fill in the required details. For approval I'll ask Chris Peterson.

Comment 8

[BMO Automation]

Attachment: GitHub Pull Request

Comment 9

[Donal Meehan [:dmeehan]]

Setting 107 to fixed, PR was merged into the 107 release branch.
The fix will be available in Fenix/Focus 107.0b5.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a0a125fa1b1
[components] Bug #1795949 - Dismiss ChoiceDialogFragment only when it is attached