Closed Bug 1795957 Opened 3 years ago Closed 3 years ago

"Only Show on New tab" no longer shows Bookmarks Toolbar upon opening a new tab (browser.toolbars.bookmarks.visibility: newtab)

Categories

(Firefox :: Toolbars and Customization, defect)

Firefox 106
Desktop
Windows
defect

Tracking

()

RESOLVED DUPLICATE of bug 1676492

People

(Reporter: tokillthebug, Unassigned)

Details

Attachments

(1 file)

Steps to reproduce:

Opened a new tab.

Actual results:

A new tab opened.

Expected results:

The bookmarks toolbar should have shown (because browser.toolbars.bookmarks.visibility: newtab).

The menu choice for Bookmarks Toolbar -> "Only Show on New tab" is checked/on.

The Bookmarks Toolbar is present.
I can toggle its visibility with Ctrl-Shift+B (which I am aware does reset "Only Show on New Tab", so I have to check it again manually, but this is new with this 106.0).

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Bookmarks & History

106.1 did not resolve this issue.

OS: Unspecified → Windows
Hardware: Unspecified → Desktop
Summary: browser.toolbars.bookmarks.visibility: newtab → "Only Show on New tab" no longer shows Bookmarks Toolbar upon opening a new tab (browser.toolbars.bookmarks.visibility: newtab)

The shortcut "ctrl+shift+b" only lets you cycle between two options: "always show" and "never show".
You cannot set "only show on new tabs" by using the shortcut.

I believe this has always been the case, not only from Fx 106.
You can set this either by using the context menu or by setting "browser.toolbars.bookmarks.visibility" to "newtab" manually.

I'm setting this as an enhancement to get it checked out by the devs but I do not think it would make sense to have a separate shortcut just for this option.

Status: UNCONFIRMED → NEW
Type: defect → enhancement
Ever confirmed: true

I'm reporting a defect. I'm not requesting a keyboard shortcut. Please read the steps to reproduce and confirm whether you can reproduce it.

Again, the defect is that, when opening a new tab, the Bookmarks Toolbar no longer shows when newtab is set, or the Only Show on New Tab is checked in the menu.

You seem to have missed the part where I say I'm aware of that I have to set newtab manually after forcing the bookmarks toolbar to show using a keyboard shortcut, but the way I set Only Show on New Tab is not through about:config, but through a menu choice.

Maybe you were not aware of that there's a menu choice for it, but that doesn't explain why you didn't check the claim I was making.
Anyway. If you click on a blank space after the + (after the last tab), you should get a menu choice for the Bookmarks Toolbar, and in its sub-menu you'll find Only Show on New Tab, which is no longer respected starting with 106, and that's what the defect report is about.

The steps given in the description weren't clear enough and I'm not able to reproduce the issue.

Maybe you were not aware of that there's a menu choice for it, but that doesn't explain why you didn't check the claim I was making.
Anyway. If you click on a blank space after the + (after the last tab), you should get a menu choice for the Bookmarks Toolbar, and in its sub-menu you'll find Only Show on New Tab, which is no longer respected starting with 106, and that's what the defect report is about.

  • I'm well aware that there is a menu choice for it hence why I even mentioned it in Comment 4.
    "You can set this either by using the context menu or by setting..."

Could you check if this also occurs for you in troubleshoot mode?
https://support.mozilla.org/en-US/kb/diagnose-firefox-issues-using-troubleshoot-mode#w_how-to-start-firefox-in-troubleshoot-mode

Status: NEW → UNCONFIRMED
Type: enhancement → defect
Ever confirmed: false
Flags: needinfo?(tokillthebug)

(In reply to Peter_M from comment #7)

Could you check if this also occurs for you in troubleshoot mode?
https://support.mozilla.org/en-US/kb/diagnose-firefox-issues-using-troubleshoot-mode#w_how-to-start-firefox-in-troubleshoot-mode

It also occurs in troubleshooting mode.

I suspect you need to try it in a browser session that runs using the "Always use private browsing mode". (Search for "always use" in Settings.)

Flags: needinfo?(tokillthebug)

106.0.2 does not fix this issue.

I have this problem on an intel Mac, but not on Apple Silicon, both running 12.6.1, and before that 12.6 It is not resolved in 106.0.1 or 106.0.2 The Bookmark Toolbars will only show if set to "Always Show." You should not need to be in Private mode to see the problem if it can be reproduced; the behavior for me is the same in both standard and private browsing modes.

Reporter, what do you have the new tab page set to? Is it a blank page, or something else? If so, this is a duplicate of bug 1676492

(In reply to jon from comment #10)

I have this problem on an intel Mac, but not on Apple Silicon, both running 12.6.1, and before that 12.6 It is not resolved in 106.0.1 or 106.0.2

Your issue is most likely bug 1676492.

Component: Bookmarks & History → Toolbars and Customization
Flags: needinfo?(tokillthebug)

(In reply to Mark Banner (:standard8) from comment #11)

Reporter, what do you have the new tab page set to? Is it a blank page, or something else? If so, this is a duplicate of bug 1676492

(In reply to jon from comment #10)

I have this problem on an intel Mac, but not on Apple Silicon, both running 12.6.1, and before that 12.6 It is not resolved in 106.0.1 or 106.0.2

Your issue is most likely bug 1676492.

Thanks! 1676492 seems to describe the difference between my two Macs' ffx preferences. Although I didn't have this problem a month ago; pretty sure this has been intermittent. I presume it returned in 106. Looks like it is soon to be fixed though.

106.0.3 did not fix the issue.

New observation: Only Show on New Tab is only respected when starting the browser, not when opening new tabs (Ctrl-T/New Tab from menu/+ button). That means there is a difference in how some internal logic treats "the first new tab opened by Firefox" and "consecutive new tabs opened by the user".

Steps to reproduce:
Assume: "new tab behavior" = "blank page" (to answer your question)
Assume: Private mode

  1. Set Bookmarks Toolbar to Only Show on New Tab
  2. Restart Firefox
  3. Observe that Firefox opens a blank tab, and shows the bookmark toolbar = it respects the option
  4. Now, open a new tab, and observe that Firefox does not show the bookmarks toolbar on any new tab the user opens (using Ctrl-T/New Tab menu/+ button). I verified that Only Show on New Tab was still checked after opening new tabs using Ctrl-T/New Tab menu/+ button.

So when Firefox starts, it automatically opens a blank page, and shows the bookmarks toolbar if Only Show on New Tab is checked, but if the user opens a new tab (Ctrl-T/New Tab menu/+ button), Firefox does not respect Only Show on New Tab.

Flags: needinfo?(tokillthebug)

As the new tab page is set to a blank page, this is a duplicate of bug 1676492. The fix for that bug has just landed in Firefox 108 which will be due out in just over a month.

Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Duplicate of bug: 1676492
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: