Open Bug 1795965 Opened 3 years ago Updated 2 years ago

Remove or replace TabsToolbarFeature

Categories

(Firefox for Android :: Tabs, task)

All
Android
task

Tracking

()

People

(Reporter: csadilek, Unassigned)

References

Details

From github: https://github.com/mozilla-mobile/android-components/issues/9129.

Currently usage of this feature looks like:

TabsToolbarFeature(
  toolbar = layout.toolbar,
  store = components.store,
  sessionId = sessionId,
  lifecycleOwner = viewLifecycleOwner,
  showTabs = ::showTabs
)

We create an instance of the feature that is never used. It just internally creates a button and adds it to the toolbar. In addition, the feature is currently not lifecycle aware which required workarounds in the TabCounterToolbarButton it creates internally (e.g. a weak reference to the TabCounter).

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(cpeterson)
Severity: -- → N/A
Type: defect → task
Flags: needinfo?(cpeterson)
See Also: → 1871177
You need to log in before you can comment on or make changes to this bug.