1795986 - URL bar buttons too short in compact mode after bug 1790616

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[Sam Johnson]

Attachment: Screen Shot 2022-10-18 at 3.14.22 PM.png

See attached screenshot. Buttons at the end of the toolbar are a little bit too short now, so they aren't aligned correctly.

Comment 1

[Sam Johnson]

Can't seem to edit the initial comment:

• This is regarding buttons at the end of the URL bar, not the end of the toolbar (words are hard!)
• This happens for compact density only

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1790616, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

I don't see this on Linux, on which OS did that happen?

I suspect given the state of compact mode this is not super prioritary but still happy to look into it if I can repro...

Comment 4

[Sam Johnson]

This was observed on macOS.

Comment 5

[Sam Johnson]

I've investigated this a bit, and it turns out that the issue isn't the buttons-- on macOS, the larger urlbar text is now increasing both the urlbar and toolbar height by 2px versus other platforms, which also causes the searchbar to be a different height than the urlbar.

It seems that removing the line-height rule added by bug 1402368 resolves this issue. I did some testing with the repro links from that bug, and as far as I can tell urlbar behavior has changed since that bug, so the issue that was being worked around no longer occurs in the first place.

I'll put up a patch with the fix.

Comment 6

[Sam Johnson]

Attachment: Bug 1795986 - Fix compact mode urlbar icon alignment and macOS toolbar height r?#desktop-theme-reviewers

Modern flexbox increased the macOS compact mode toolbar height by 2px due to a line-height rule from bug 1402368. The issue from that bug no longer reproduces on current Nightly, even without the added rule, so it seems safe to remove.

There was also some extra spacing introduced with Proton that should have been only applied to the search "go" button, so I scoped that more tightly and also fixed the alignment of that button while at it.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1790616

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12125609df3b
Fix compact mode urlbar icon alignment and macOS toolbar height r=desktop-theme-reviewers,dao,Gijs,Itiel

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/12125609df3b

Comment 10

[Monica Chiorean]

I installed on Mac 10.13, FF build 108.0a1(20221017213658) and I see no difference between this build and release build 108.0(20221205155917) regarding the two buttons. Is there a way I can check the fix? Or can you please confirm issue is fixed on your side on latest 108.0 build? thank you so much.

Comment 11

[Sam Johnson]

I think the first build that contained the regression was 20221018094831.