Improve sync-messages.ini checking
Categories
(Core :: IPC, task, P3)
Tracking
()
People
(Reporter: mccr8, Unassigned)
References
Details
As seen in bug 1796013, it would be nice if it was an error if a protocol wasn't seen at all but it has sync-messages.ini entry. In general, this would require adding pre-processing to sync-messages.ini. I'm not sure how many protocols with sync messages are only built under special ifdefs. Locally, I got an error for PSandboxTesting when doing an opt build.
It would also be nice if we actually checked the platform tag. Right now, the way it works is that if it has any kind of platform tag then we ignore if the message is missing. Currently, the only platform tags used are mac, win and notwin. Potentially we could realize that we are currently building for Windows, and then complain if a message with the win tag is not present.
The goal here is to avoid having defunct stuff in the sync-messages file.
|
Reporter | |
Comment 1•3 years ago
|
||
Platform checking would find things like PDocAccessible::ARIARoleAtom, which is a message which is no longer defined on PDocAccessible on any platform.
|
|
Reporter | |
Comment 2•3 years ago
|
||
After my patch in bug 1796013, the only messages on an OSX opt build in the "fixed" set are: PCompositorWidget::LeavePresentLock, PCompositorWidget::EnterPresentLock, PDocAccessible::SyncTextChangeEvent, PCompositorWidget::ClearTransparentWindow, PSandboxTesting::GetSpecialDirectory, PCompositorWidget::Initialize, PRemoteSandboxBroker::LaunchApp. The list will be much longer on Windows because there are a ton of "notwin" entries.
Description
•