Closed Bug 1796040 Opened 2 years ago Closed 2 years ago

Old private browsing indicator does not align correctly

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Version:
Firefox 108
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox106 --- unaffected
firefox107 --- unaffected
firefox108 --- verified

People

(Reporter: Fanolian+BMO, Assigned: emilio)

References

(Regression)

Details

(Keywords: nightly-community, regression, reproducible)

Attachments

(2 files)

Old PB indicator.png
7.98 KB, image/png
Details
Bug 1796040 - Remove unnecessary explicit height for old PB indicator. r=dao,pbz,Gijs
48 bytes, text/x-phabricator-request
Details | Review
Attached image Old PB indicator.png —

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:108.0) Gecko/20100101 Firefox/108.0
Build ID: 20221018213916

Steps to reproduce

  1. Set browser.privatebrowsing.enable-new-indicator to false.
  2. Open a private window.
  3. Observe the PB indicator on top right.

Actual result

The indicator shifts up.

Notes

The new, default PB indicator is not affected.

Regression

Last good Nightly: 2022-10-17
First bad Nightly: 2022-10-18
pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ac1330b68d3e7b231a177cfa1ac52e1b2199bb84&tochange=b6e04e02b4f8532eac41194d203e72d91dbfc2ff

Bisecting autoland builds:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a41265da4a2a475ed7cde77c9aa285ecdf413f3b&tochange=d728a45552226ef4a36bab51796d60931e13582c

This is probably regressed by bug 1790616.

Flags: needinfo?(emilio)
Has STR: --- → yes
Keywords: nightly-community, regression, reproducible
Regressed by: 1790616
Flags: needinfo?(emilio)

As with new flexbox it gets honored, and breaks the stretching.

There's the question of whether we should remove all the old indicator
code entirely tho...

Assignee: nobody → emilio
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Set release status flags based on info from the regressing bug 1790616

status-firefox106: --- → unaffected
status-firefox107: --- → unaffected
status-firefox108: --- → affected
status-firefox-esr102: --- → unaffected
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bee49b4c1c33
Remove unnecessary explicit height for old PB indicator. r=pbz,Gijs

https://hg.mozilla.org/mozilla-central/rev/bee49b4c1c33

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox108: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
Flags: qe-verify+

Reproduced the issue in Nightly 108.0a1 (build id: 20221018094831) using Windows 10.
Verified - Fixed in Beta 108.0b3 and the latest Nightly 109.0a1 (2022-11-18) on Windows 10, macOS 12 and Ubuntu 20.

Status: RESOLVED → VERIFIED
status-firefox108: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: