1796044 - [TSF] Make `TSFTextStore` use static prefs

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, enhancement, P3)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1796044 - part 1: Make `intl.ime.hack.set_input_scope_of_url_bar_to_default` a static pref r=m_kato!

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1796044 - part 2: Make `intl.tsf.hack.allow_to_stop_hacking_on_build_17643_or_later` a static pref r=m_kato!

Depends on D159804

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1796044 - part 3: Make `intl.tsf.hack.atok.create_native_caret` a static pref r=m_kato!

Depends on D159805

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1796044 - part 4: Make `intl.tsf.hack.atok.do_not_return_no_layout_error_of_composition_string` a static pref r=m_kato!

Depends on D159806

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1796044 - part 5: Make `intl.tsf.hack.japanist10.do_not_return_no_layout_error_of_composition_string` a static pref r=m_kato!

Depends on D159807

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1796044 - part 6: Make `intl.tsf.hack.free_chang_jie.do_not_return_no_layout_error_of_composition_string` a static pref r=m_kato!

Depends on D159808

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1796044 - part 7: Make `intl.tsf.hack.ms_simplified_chinese.do_not_return_no_layout_error_of_composition_string` a static pref r=m_kato!

Depends on D159809

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1796044 - part 8: Make `intl.tsf.hack.ms_traditional_chinese.do_not_return_no_layout_error_of_composition_string` a static pref r=m_kato!

Depends on D159810

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1796044 - part 9: Make `intl.tsf.hack.ms_japanese_ime.do_not_return_no_layout_error_at_first_char` a static pref r=m_kato!

Depends on D159811

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1796044 - part 10: Make `intl.tsf.hack.ms_japanese_ime.do_not_return_no_layout_error_at_caret` a static pref r=m_kato!

Depends on D159812

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1796044 - part 11: Make `intl.tsf.hack.ms_simplified_chinese.query_insert_result` a static pref r=m_kato!

Depends on D159813

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1796044 - part 12: Make `intl.tsf.hack.ms_traditional_chinese.query_insert_result` a static pref r=m_kato!

Depends on D159814

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1796044 - part 13: Make `intl.tsf.hack.atok.search_input_scope_disabled` a static pref r=m_kato!

Depends on D159815

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1796044 - part 14: Get rid of `intl.tsf.associate_imc_only_when_imm_ime_is_active` r=m_kato!

It's introduced in bug 1367692 to make it possible to test the bug of old
MS-IME on Windows 10 with later versions. Now, the bug and the old versions
have gone. Therefore, we don't need this pref anymore.

Depends on D159816

Comment 15

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1796044 - part 15: Make `intl.tsf.support_imm` a static pref r=m_kato!

This pref is used for behavior check of how newer TSF behave without IMC.
Therefore, this shouldn't be used by users. However, like bug 1367692 and
bug 1409155, this may be useful when we meet a critical bug of old IME in
newer Windows. Thus we should keep this pref.

Depends on D159817

Comment 16

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1796044 - part 16: Make `intl.tsf.enable` a static pref and rename it r=m_kato!

Some users may keep disabling TSF while we were improving TSF implementation due
to avoiding some bugs.

Currently, we don't test IMM handler. Therefore, I think that we should rename
the pref and make users run well-tested path to handle IME.

Depends on D159818

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/258be5695fce
part 1: Make `intl.ime.hack.set_input_scope_of_url_bar_to_default` a static pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/6d68e72b4e16
part 2: Make `intl.tsf.hack.allow_to_stop_hacking_on_build_17643_or_later` a static pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/72713be26140
part 3: Make `intl.tsf.hack.atok.create_native_caret` a static pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/47016ce01e91
part 4: Make `intl.tsf.hack.atok.do_not_return_no_layout_error_of_composition_string` a static pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/dc841ab79925
part 5: Make `intl.tsf.hack.japanist10.do_not_return_no_layout_error_of_composition_string` a static pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/9c6a7cf24fbd
part 6: Make `intl.tsf.hack.free_chang_jie.do_not_return_no_layout_error_of_composition_string` a static pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/c813d81adaa9
part 7: Make `intl.tsf.hack.ms_simplified_chinese.do_not_return_no_layout_error_of_composition_string` a static pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/5a95fd94ef74
part 8: Make `intl.tsf.hack.ms_traditional_chinese.do_not_return_no_layout_error_of_composition_string` a static pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/c98cd4e50948
part 9: Make `intl.tsf.hack.ms_japanese_ime.do_not_return_no_layout_error_at_first_char` a static pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/5c9ff70a70d2
part 10: Make `intl.tsf.hack.ms_japanese_ime.do_not_return_no_layout_error_at_caret` a static pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/632de7978d1c
part 11: Make `intl.tsf.hack.ms_simplified_chinese.query_insert_result` a static pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/61a7222cabbc
part 12: Make `intl.tsf.hack.ms_traditional_chinese.query_insert_result` a static pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/1963ad289fe4
part 13: Make `intl.tsf.hack.atok.search_input_scope_disabled` a static pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/44b9d117ed70
part 14: Get rid of `intl.tsf.associate_imc_only_when_imm_ime_is_active` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/34db2cc3fd93
part 15: Make `intl.tsf.support_imm` a static pref r=m_kato
https://hg.mozilla.org/integration/autoland/rev/5e86fa229647
part 16: Make `intl.tsf.enable` a static pref and rename it r=m_kato

Comment 18

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/258be5695fce
https://hg.mozilla.org/mozilla-central/rev/6d68e72b4e16
https://hg.mozilla.org/mozilla-central/rev/72713be26140
https://hg.mozilla.org/mozilla-central/rev/47016ce01e91
https://hg.mozilla.org/mozilla-central/rev/dc841ab79925
https://hg.mozilla.org/mozilla-central/rev/9c6a7cf24fbd
https://hg.mozilla.org/mozilla-central/rev/c813d81adaa9
https://hg.mozilla.org/mozilla-central/rev/5a95fd94ef74
https://hg.mozilla.org/mozilla-central/rev/c98cd4e50948
https://hg.mozilla.org/mozilla-central/rev/5c9ff70a70d2
https://hg.mozilla.org/mozilla-central/rev/632de7978d1c
https://hg.mozilla.org/mozilla-central/rev/61a7222cabbc
https://hg.mozilla.org/mozilla-central/rev/1963ad289fe4
https://hg.mozilla.org/mozilla-central/rev/44b9d117ed70
https://hg.mozilla.org/mozilla-central/rev/34db2cc3fd93
https://hg.mozilla.org/mozilla-central/rev/5e86fa229647