1796065 - Dropdown arrow from autoplay notification panel is misplaced

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Bogdan Maris, Desktop QA]

Attachment: Bad dropdown arrow.png

Found in

• Nightly 108.0a1 (2022-10-18)

Affected versions

• Nightly 108.0a1

Unaffected versions

• Firefox 107.0b2
• Firefox 106.0

Tested platforms

• Affected platforms: Windows 10, Ubuntu 22.04, Windows 11, macOS 11.6
• Unaffected platforms: none

Steps to reproduce

1. Visit https://strifer.link/html-video-autoplay-test/
2. Click the autoplay permission notification from the URL bar

Expected result

• The dropdown arrow is placed somewhat in the middle of the dropdown button

Actual result

• The dropdown arrow has moved up and it looks out of place.

Regression range

• First bad: a41265da4a2a475ed7cde77c9aa285ecdf413f3b
• Last good: c2f047ea3f07712de2b07487607f23592409e005
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a41265da4a2a475ed7cde77c9aa285ecdf413f3b&tochange=c2f047ea3f07712de2b07487607f23592409e005
• Potentially regressed by: Mozregression pointed at bug 1795025 but I an fairly sure that that's not the case. I would rather suspect either bug 1790616 or bug 1795199, Emilio will definitely know which one.

Additional notes

• Screenshot showing the issue is attached.

Comment 1

[Bogdan Maris, Desktop QA]

Attachment: Good dropdown arrow.png

Here is a screenshot with the previous position of the dropdown arrow for reference.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1796065 - Remove unnecessary explicit size from permissions menulist dropmarker icon. r=Gijs,dao,mconley

The dropmarker is already 12px and centered, so this shouldn't be needed
and in fact breaks the stretching.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e476e9b24f5e
Remove unnecessary explicit size from permissions menulist dropmarker icon. r=Gijs

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e476e9b24f5e

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Based on comment #0, this bug contains a bisection range found by mozregression. However, the Regressed by field is still not filled.

:emilio, if possible, could you fill the Regressed by field and investigate this regression?

For more information, please visit auto_nag documentation.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Comment 5 is quite silly given the bug is already closed... Is that intentional?

Comment 7

[Suhaib Mujahid [:suhaib]]

The "investigate this regression" part is not intentional. I filed an issue earlier today to fix it: https://github.com/mozilla/relman-auto-nag/issues/1732

Comment 8

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 108.0a1 (2022-10-18) using the steps from the description on macOS 12, Windows 10 and Ubuntu 22.
The issue is verified fixed with Firefox 109.0a1 (20221117214129) on Windows 10, macOS 12 and Ubuntu 22. The drop down arrow is displayed as expected.