Closed Bug 1796250 Opened 3 years ago Closed 3 years ago

Use a unbounded queue for preinit, but have it act like a bounded queue

Categories

(Data Platform and Tools :: Glean: SDK, defect)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: perry.mcmanis, Assigned: perry.mcmanis)

References

Details

Attachments

(1 file)

We would like to evaluate making the pre-init queue considerably larger (for example, to ameliorate https://bugzilla.mozilla.org/show_bug.cgi?id=1780035), but bounded queues are fully preallocated.

Unbounded queues are linked lists that add 32 nodes at a time. In fact, for most glean initializations, this will create smaller queues, which is great, and also in the case of large pre-init queues, it can grow rather than be pre-allocated.

The only drawback is that if Glean never finishes initializing, it could grow indefinitely.

We will move the size checking to Glean to allow for the potential increase of the preinit maximum queue size.

Assignee: nobody → pmcmanis
Blocks: 1796258
Attached file GitHub Pull Request
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

Whoops, it missed a changelog entry.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: