1796263 - Change default top sites for different regions

Status: RESOLVED FIXED

(Firefox for Android :: Top Sites, task, P2)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

From github: https://github.com/mozilla-mobile/android-components/issues/8491.

This issue is to address default top sites that are currently present in existing users.

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Tech Doc: https://docs.google.com/document/d/1DkE_BgAgX9scHRlPYJFK1AAxAImAngeq4Yzlcuy9RWI/edit?usp=sharing
Context: https://docs.google.com/document/d/1mx-CSiTsxi7ZXbVgk3dCL82ZyN49FRKSYLpYEycpw7Q/edit?usp=sharing

• Changes for which regions Google default top sites should appear in.

Comment 1

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Chris Peterson [:cpeterson]]

gl wrote a bunch of code in https://github.com/mozilla-mobile/android-components/issues/8491, but I don't know if any of it was merged.

To implement this, PM will need to provide a list of new top sites for different locales.

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1796263 - Replace hard-coded default top sites to be read from JSON file

• Implements DefaultTopSitesProvider that will read the default top sites list from a JSON and return the top sites to be loaded based on the region.
• The JSON schema follows the desktop schema for default top sites: https://firefox.settings.services.mozilla.com/v1/buckets/main/collections/top-sites/records
• Future intentions would be to fetch a similar mobile compatible JSON from Remote Settings.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bdecb87aef9e
https://hg.mozilla.org/integration/autoland/rev/dd6d9b78d71a
Replace hard-coded default top sites to be read from JSON file r=android-reviewers,jonalmeida,skhan

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/dd6d9b78d71a

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1796263 - Replace hard-coded default top sites to be read from JSON file

• Implements DefaultTopSitesBinding that will read the default top sites list from a JSON and add the default top sites to storage based on the region.
• The JSON schema follows the desktop schema for default top sites: https://firefox.settings.services.mozilla.com/v1/buckets/main/collections/top-sites/records
• Future intentions would be to fetch a similar mobile compatible JSON from Remote Settings.

Original Revision: https://phabricator.services.mozilla.com/D267522

Comment 7

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/c28b4e328969
https://hg.mozilla.org/releases/mozilla-release/rev/7692ee284501

Comment 8

[Adina Petridean QA [:apetridean]]

Validated on Fenix 146.0b4 and RC 145.0.1 using Samsung Galaxy S23 Ultra (Android 14).

Google top site does not appear for: RU, TR, KZ, BY.

Wikipedia top site does not appear for: JP.

For JP, the following appear correctly: Google, Sponsored top sites, Tenky, Yahoo, Ameblo, ウィキペディア.

The only remaining issue is for China: on both Beta and RC, Google and Wikipedia are still displayed.

@gl since the other regions behave as expected, could you please double-check the CN configuration or logic on your side?
It seems this specific case might still require an adjustment.

Also, please let me know what you prefer:
should I reopen this bug, or
should I file a new one specifically for the CN issue?

Thanks!