Closed Bug 1796295 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36561 - Stop conservatively rejecting none/normal/auto on newer <custom-ident> values.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox108 fixed)

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36561 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36561
Details from upstream follow.

L. David Baron <dbaron@chromium.org> wrote:

Stop conservatively rejecting none/normal/auto on newer <custom-ident> values.

In https://github.com/w3c/csswg-drafts/issues/7431 the CSS Working Group
resolved not to try to restrict none/normal/auto keywords, so there's no
need to reject them to avoid worsening potential compatibility problems.

Based on specs at https://drafts.csswg.org/css-contain-3/#container-name
and https://drafts.csswg.org/css-contain-3/#container-rule, this adjusts
ConsumeSingleContainerName to accept 'normal' and instead reject 'none'.

Fixed: 1340852
Change-Id: I53b78e412b0797210c1b5463401bcc055f7bd550

Reviewed-on: https://chromium-review.googlesource.com/3966666
WPT-Export-Revision: 008456f76249cb899bab4e389aafcfff13c787a3

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 42 subtests

Status Summary

Firefox

OK : 3[GitHub] 6[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt]
PASS : 20[GitHub] 178[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt]
FAIL : 57[GitHub] 93[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt]
ERROR: 3

Chrome

OK : 6
PASS : 214
FAIL : 57

Safari

OK : 6
PASS : 199
FAIL : 72

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-contain/container-queries/at-container-parsing.html [wpt.fyi]: ERROR [GitHub], OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
    • not (width: 100px): FAIL (Chrome: PASS, Safari: PASS)
    • foo(width): FAIL (Chrome: PASS, Safari: PASS)
    • size(width): FAIL (Chrome: PASS, Safari: PASS)
    • (asdf): FAIL (Chrome: PASS, Safari: PASS)
    • (resolution > 100dpi): FAIL (Chrome: PASS, Safari: PASS)
    • (resolution: 150dpi): FAIL (Chrome: PASS, Safari: PASS)
    • (color): FAIL (Chrome: PASS, Safari: PASS)
    • (min-color: 1): FAIL (Chrome: PASS, Safari: PASS)
    • (color-index >= 1): FAIL (Chrome: PASS, Safari: PASS)
    • size(grid): FAIL (Chrome: PASS, Safari: PASS)
    • (grid): FAIL (Chrome: PASS, Safari: PASS)
    • (width == 100px): FAIL (Chrome: PASS, Safari: PASS)
    • (100px == width): FAIL (Chrome: PASS, Safari: PASS)
    • (100px = width = 200px): FAIL (Chrome: PASS, Safari: PASS)
    • (100px < width > 200px): FAIL (Chrome: PASS, Safari: PASS)
    • (100px <= width >= 200px): FAIL (Chrome: PASS, Safari: PASS)
    • (100px <= width > 200px): FAIL (Chrome: PASS, Safari: PASS)
    • (100px < width >= 200px): FAIL (Chrome: PASS, Safari: PASS)
    • (100px : width : 200px): FAIL (Chrome: PASS, Safari: PASS)
    • foo (width: 100px): FAIL (Chrome: PASS, Safari: PASS)
    • name not (width <= 500px): FAIL (Chrome: PASS, Safari: PASS)
    • Container name: foo: FAIL (Chrome: PASS, Safari: PASS)
    • Container name: foo: FAIL (Chrome: PASS, Safari: PASS)
    • Container name: foo : FAIL (Chrome: PASS, Safari: PASS)
    • Container name: normal: FAIL (Chrome: FAIL, Safari: FAIL)
    • Container name: Normal: FAIL (Chrome: FAIL, Safari: FAIL)
    • Container name: auto: FAIL (Chrome: FAIL, Safari: FAIL)
    • Container name: Auto: FAIL (Chrome: FAIL, Safari: FAIL)
    • Container name: none: FAIL (Chrome: PASS, Safari: PASS)
    • Container name: None: FAIL (Chrome: PASS, Safari: PASS)
    • style(--my-prop: foo): FAIL (Chrome: PASS, Safari: FAIL)
    • style(--my-prop: foo - bar ()): FAIL (Chrome: PASS, Safari: FAIL)
    • style(not ((--foo: calc(10px + 2em)) and ((--foo: url(x))))): FAIL (Chrome: PASS, Safari: FAIL)
    • style((--foo: bar) or (--bar: 10px)): FAIL (Chrome: PASS, Safari: FAIL)
    • style(--my-prop:): FAIL (Chrome: PASS, Safari: FAIL)
    • style(--my-prop: ): FAIL (Chrome: PASS, Safari: FAIL)
    • style(--foo: bar !important): FAIL (Chrome: PASS, Safari: FAIL)
    • style(--foo: bar;): FAIL (Chrome: PASS, Safari: PASS)
    • style(--foo): FAIL (Chrome: PASS, Safari: PASS)
    • style(style(--foo: bar)): FAIL (Chrome: PASS, Safari: PASS)
  • /css/css-contain/container-queries/container-name-parsing.html [wpt.fyi]: ERROR [GitHub], OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
    • e.style['container-name'] = "auto" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['container-name'] = "normal" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-contain/container-queries/container-parsing.html [wpt.fyi]: ERROR [GitHub], OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
    • e.style['container'] = "normal / size" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['container'] = "auto / size" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • /scroll-animations/css/scroll-timeline-name-parsing.tentative.html [wpt.fyi]
    • e.style['scroll-timeline-name'] = "initial" should set the property value: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: PASS, Safari: FAIL)
    • e.style['scroll-timeline-name'] = "inherit" should set the property value: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: PASS, Safari: FAIL)
    • e.style['scroll-timeline-name'] = "unset" should set the property value: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: PASS, Safari: FAIL)
    • e.style['scroll-timeline-name'] = "revert" should set the property value: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: PASS, Safari: FAIL)
    • e.style['scroll-timeline-name'] = "none" should set the property value: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: PASS, Safari: FAIL)
    • e.style['scroll-timeline-name'] = "abc" should set the property value: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: PASS, Safari: FAIL)
    • e.style['scroll-timeline-name'] = " abc" should set the property value: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: PASS, Safari: FAIL)
    • e.style['scroll-timeline-name'] = "aBc" should set the property value: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: PASS, Safari: FAIL)
    • e.style['scroll-timeline-name'] = "auto" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • /scroll-animations/css/view-timeline-name-parsing.html [wpt.fyi]
    • e.style['view-timeline-name'] = "initial" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "inherit" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "unset" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "revert" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "none" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "abc" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = " abc" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "abc " should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "aBc" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "foo, bar" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "bar, foo" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "none, none" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "a, none, b" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline-name'] = "auto" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • /scroll-animations/css/view-timeline-shorthand.tentative.html [wpt.fyi]
    • e.style['view-timeline'] = "abcd" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "none block" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "none inline" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "inline block" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "block block" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "vertical block" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "horizontal block" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "a, b, c" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "a inline, b block, c vertical" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "auto" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'abcd': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'none block': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'none inline': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'inline block': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'block block': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'vertical block': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'horizontal block': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'a, b, c': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property view-timeline value 'a inline, b block, c vertical': FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc vertical" should set view-timeline-axis: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc vertical" should set view-timeline-name: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc vertical" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc vertical, def" should set view-timeline-axis: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc vertical, def" should set view-timeline-name: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc vertical, def" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc, def" should set view-timeline-axis: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc, def" should set view-timeline-name: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "abc, def" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "inline horizontal" should set view-timeline-axis: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "inline horizontal" should set view-timeline-name: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['view-timeline'] = "inline horizontal" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • Shorthand contraction of view-timeline-name:abc;view-timeline-axis:inline: FAIL (Chrome: FAIL, Safari: FAIL)
    • Shorthand contraction of view-timeline-name:a, b;view-timeline-axis:inline, block: FAIL (Chrome: FAIL, Safari: FAIL)
    • Shorthand contraction of view-timeline-name:none, none;view-timeline-axis:block, block: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/507451b49b2d [wpt PR 36561] - Stop conservatively rejecting none/normal/auto on newer <custom-ident> values., a=testonly https://hg.mozilla.org/integration/autoland/rev/654b45298452 [wpt PR 36561] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/507451b49b2d
https://hg.mozilla.org/mozilla-central/rev/654b45298452

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.